gemini comments

Author: daniel-sanche

packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py

@@ -1113,11 +1113,11 @@ def coalesce(self, *others: Expression | CONSTANT_TYPE) -> "Expression":
         Returns:
             An Expression representing the coalesce operation.
         """
-        args = [self]
-        args.extend(
-            [Expression._cast_to_expr_or_convert_to_constant(x) for x in others]
+        return FunctionExpression(
+            "coalesce",
+            [self]
+            + [Expression._cast_to_expr_or_convert_to_constant(x) for x in others],
         )
-        return FunctionExpression("coalesce", args)
 
     @expose_as_static
     def switch_on(
@@ -1141,13 +1141,13 @@ def switch_on(
             *others: Additional alternating conditions and results, optionally followed by a default value.
 
         Returns:
-            An Expression representing the switchOn operation.
+            An Expression representing the "switch_on" operation.
         """
-        args = [self, Expression._cast_to_expr_or_convert_to_constant(result)]
-        args.extend(
-            [Expression._cast_to_expr_or_convert_to_constant(x) for x in others]
+        return FunctionExpression(
+            "switch_on",
+            [self, Expression._cast_to_expr_or_convert_to_constant(result)]
+            + [Expression._cast_to_expr_or_convert_to_constant(x) for x in others],
         )
-        return FunctionExpression("switch_on", args)
 
     @expose_as_static
     def storage_size(self) -> "Expression":

packages/google-cloud-firestore/tests/unit/v1/test_pipeline_expressions.py

@@ -750,8 +750,8 @@ def test_array_get(self):
         assert instance.name == "array_get"
         assert instance.params == [arg1, arg2]
         assert repr(instance) == "ArrayField.array_get(Offset)"
-        infix_istance = arg1.array_get(arg2)
-        assert infix_istance == instance
+        infix_instance = arg1.array_get(arg2)
+        assert infix_instance == instance
 
     def test_offset(self):
         arg1 = self._make_arg("ArrayField")
@@ -760,8 +760,8 @@ def test_offset(self):
         assert instance.name == "offset"
         assert instance.params == [arg1, arg2]
         assert repr(instance) == "ArrayField.offset(Offset)"
-        infix_istance = arg1.offset(arg2)
-        assert infix_istance == instance
+        infix_instance = arg1.offset(arg2)
+        assert infix_instance == instance
 
     def test_array_contains(self):
         arg1 = self._make_arg("ArrayField")
@@ -1654,8 +1654,8 @@ def test_array_reverse(self):
         assert instance.name == "array_reverse"
         assert instance.params == [arg1]
         assert repr(instance) == "ArrayField.array_reverse()"
-        infix_istance = arg1.array_reverse()
-        assert infix_istance == instance
+        infix_instance = arg1.array_reverse()
+        assert infix_instance == instance
 
     def test_array_filter(self):
         arg1 = self._make_arg("ArrayField")