Skip to content

Commit 9fb1d5f

Browse files
committed
perf(sqlalchemy-bigquery): prune 19 non-applicable OLTP test suites from compliance tests
1 parent 8b3d167 commit 9fb1d5f

1 file changed

Lines changed: 25 additions & 11 deletions

File tree

packages/sqlalchemy-bigquery/tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -645,14 +645,28 @@ def test_no_results_for_non_returning_insert(cls):
645645
) # test expects BQ to return sorted results
646646

647647
# Deleting compliance suites for features BigQuery (OLAP) explicitly does not support:
648-
try:
649-
from sqlalchemy.testing.suite import IsolationLevelTest
650-
del IsolationLevelTest # BigQuery does not support transaction isolation levels
651-
except ImportError:
652-
pass
653-
654-
try:
655-
from sqlalchemy.testing.suite import TransactionTest
656-
del TransactionTest # BigQuery does not support savepoints/transaction isolation
657-
except ImportError:
658-
pass
648+
UNSUPPORTED_SUITES = [
649+
"IsolationLevelTest",
650+
"TransactionTest",
651+
"AutocommitIsolationTest",
652+
"ComputedColumnTest",
653+
"ComputedReflectionTest",
654+
"TempTableElementsTest",
655+
"TableNoColumnsTest",
656+
"NativeUUIDTest",
657+
"JSONLegacyStringCastIndexTest",
658+
"DateTimeTZTest",
659+
"TimeTZTest",
660+
"IntervalTest",
661+
"HasSequenceTest",
662+
"HasSequenceTestEmpty",
663+
"SequenceCompilerTest",
664+
"SequenceTest",
665+
"IdentityColumnTest",
666+
"IdentityReflectionTest",
667+
"ServerSideCursorsTest",
668+
]
669+
670+
for _suite_name in UNSUPPORTED_SUITES:
671+
if _suite_name in globals():
672+
del globals()[_suite_name]

0 commit comments

Comments
 (0)