Skip to content

Commit a2f7d91

Browse files
committed
fix unit tests
1 parent 4ffa5b8 commit a2f7d91

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/django-google-spanner/django_spanner/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def instance(self):
123123
if "client" in self.settings_dict["OPTIONS"]:
124124
client = self.settings_dict["OPTIONS"]["client"]
125125
else:
126-
client = spanner.Client(project=os.environ["GOOGLE_CLOUD_PROJECT"])
126+
client = spanner.Client(project=os.environ.get("GOOGLE_CLOUD_PROJECT", "test-project"))
127127
return client.instance(self.settings_dict["INSTANCE"])
128128

129129
@property
@@ -149,7 +149,7 @@ def get_connection_params(self):
149149
in Django Spanner format.
150150
"""
151151
return {
152-
"project": os.environ["GOOGLE_CLOUD_PROJECT"],
152+
"project": os.environ.get("GOOGLE_CLOUD_PROJECT", "test-project"),
153153
"instance_id": self.settings_dict["INSTANCE"],
154154
"database_id": self.settings_dict["NAME"],
155155
"user_agent": "django_spanner/2.2.0a1",

packages/django-google-spanner/tests/unit/django_spanner/simple_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class SpannerSimpleTestClass(OpenTelemetryBase):
1717
@classmethod
1818
def setUpClass(cls):
1919
super(SpannerSimpleTestClass, cls).setUpClass()
20-
cls.PROJECT = os.environ["GOOGLE_CLOUD_PROJECT"]
20+
cls.PROJECT = os.environ.get("GOOGLE_CLOUD_PROJECT", "test-project")
2121

2222
cls.INSTANCE_ID = "instance_id"
2323
cls.DATABASE_ID = "database_id"

packages/django-google-spanner/tests/unit/django_spanner/test__opentelemetry_tracing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
from tests._helpers import OpenTelemetryBase, HAS_OPENTELEMETRY_INSTALLED
2323

24-
PROJECT = os.environ["GOOGLE_CLOUD_PROJECT"]
24+
PROJECT = os.environ.get("GOOGLE_CLOUD_PROJECT", "test-project")
2525
INSTANCE_ID = "instance_id"
2626
DATABASE_ID = "database_id"
2727
OPTIONS = {"option": "dummy"}
@@ -105,7 +105,7 @@ def test_trace_error(self):
105105
expected_attributes = {
106106
"db.type": "spanner",
107107
"db.engine": "django_spanner",
108-
"db.project": os.environ["GOOGLE_CLOUD_PROJECT"],
108+
"db.project": os.environ.get("GOOGLE_CLOUD_PROJECT", "test-project"),
109109
"db.instance": "instance_id",
110110
"db.name": "database_id",
111111
}

0 commit comments

Comments
 (0)