Skip to content

Commit a331c0e

Browse files
committed
address PR feedback
1 parent 2d7e533 commit a331c0e

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

.github/workflows/gapic-generator-tests.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ concurrency:
1717
env:
1818
SHOWCASE_VERSION: 0.35.0
1919
PROTOC_VERSION: 3.20.2
20-
OLDEST_PYTHON: 3.9
2120
LATEST_STABLE_PYTHON: 3.14
22-
PREVIEW_PYTHON_VERSION: 3.14
2321
ALL_PYTHON: "['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']"
2422

2523
jobs:
@@ -48,7 +46,6 @@ jobs:
4846
runs-on: ubuntu-latest
4947
outputs:
5048
all_python: ${{ env.ALL_PYTHON }}
51-
oldest_python: ${{ env.OLDEST_PYTHON }}
5249
latest_stable_python: ${{ env.LATEST_STABLE_PYTHON }}
5350
steps:
5451
- run: echo "Initializing config for gapic-generator"
@@ -91,7 +88,7 @@ jobs:
9188
- name: Set up Python
9289
uses: actions/setup-python@v6
9390
with:
94-
python-version: ${{ env.LATEST_STABLE_PYTHON }}
91+
python-version: ${{ needs.python_config.outputs.latest_stable_python }}
9592
- name: Run Mypy
9693
run: |
9794
pip install nox
@@ -114,7 +111,7 @@ jobs:
114111
pip install nox
115112
cd packages/gapic-generator
116113
for pkg in credentials eventarc logging redis; do
117-
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ env.LATEST_STABLE_PYTHON }}
114+
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ needs.python_config.outputs.latest_stable_python }}
118115
done
119116
120117
goldens-prerelease:
@@ -125,15 +122,15 @@ jobs:
125122
- name: Set up Python
126123
uses: actions/setup-python@v6
127124
with:
128-
python-version: ${{ env.LATEST_STABLE_PYTHON }}
125+
python-version: ${{ needs.python_config.outputs.latest_stable_python }}
129126
- name: Install System Deps
130127
run: sudo apt-get update && sudo apt-get install -y pandoc
131-
- name: Run Goldens (Lint/Unit)
128+
- name: Run Goldens (Prerelease)
132129
run: |
133130
pip install nox
134131
cd packages/gapic-generator
135132
for pkg in credentials eventarc logging redis; do
136-
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ env.LATEST_STABLE_PYTHON }}
133+
nox -f tests/integration/goldens/$pkg/noxfile.py -s prerelease
137134
done
138135
139136
fragment-snippet:
@@ -163,6 +160,6 @@ jobs:
163160
# Run fragment for current matrix python
164161
nox -s fragment-${{ matrix.python }}
165162
# Run snippetgen only on the latest stable to avoid the "Python not found" error
166-
if [ "${{ matrix.python }}" == "${{ env.LATEST_STABLE_PYTHON }}" ]; then
163+
if [ "${{ matrix.python }}" == "${{ needs.python_config.outputs.latest_stable_python }}" ]; then
167164
nox -s snippetgen
168165
fi

0 commit comments

Comments
 (0)