Skip to content

Commit a719055

Browse files
authored
fix(gapic-generator): remove lagging 3.9 refs (#16924)
> [!note] > This PR was in a holding pattern. It should be merged now that we have removed the references to 3.9 in the repo (via generation of the GAPIC libraries and via updates to the handwritten libs) Removes two lagging refs to 3.9 to finalize the migration of the gapic generator codebase to 3.10+ runtime dependencies. Fixes #[internal issue](http://b/482126936) 🦕
1 parent 00eb128 commit a719055

3 files changed

Lines changed: 2 additions & 13 deletions

File tree

.github/workflows/unittest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: true
2020
matrix:
21-
python: ['3.9', '3.10', "3.11", "3.12", "3.13", "3.14"]
21+
python: ['3.10', "3.11", "3.12", "3.13", "3.14"]
2222
steps:
2323
- name: Checkout
2424
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6

ci/run_single_test.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,6 @@ case ${TEST_TYPE} in
7070
;;
7171
unit)
7272
case ${PY_VERSION} in
73-
"3.9")
74-
if nox --list-sessions | grep -q "unit-3.9"; then
75-
nox -s unit-3.9
76-
retval=$?
77-
else
78-
echo "Skipping unit-3.9 as it is not supported by this package."
79-
retval=0
80-
fi
81-
;;
8273
"3.10")
8374
nox -s unit-3.10
8475
retval=$?

packages/gapic-generator/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
RUFF_EXCLUDES = "*golden*,*pb2.py,*pb2.pyi"
4545

4646
ALL_PYTHON = (
47-
"3.9",
4847
"3.10",
4948
"3.11",
5049
"3.12",
@@ -59,8 +58,7 @@
5958
@nox.session(python=ALL_PYTHON)
6059
def unit(session):
6160
"""Run the unit test suite."""
62-
if session.python == "3.9":
63-
session.skip("Skipping Python 3.9 unit tests temporarily.")
61+
6462
session.install(
6563
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2478):
6664
# Temporarily pin coverage to 7.11.0

0 commit comments

Comments
 (0)