Skip to content

Commit ac1087d

Browse files
committed
fix(api-core): format files and add test coverage for universe helper
1 parent 86fea61 commit ac1087d

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

packages/google-api-core/google/api_core/universe.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,4 +195,3 @@ def get_api_endpoint(
195195
return default_mtls_endpoint
196196
else:
197197
return default_endpoint_template.format(UNIVERSE_DOMAIN=universe_domain)
198-

packages/google-api-core/tests/unit/test_universe.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
# limitations under the License.
1414

1515
import pytest
16+
from google.auth.exceptions import MutualTLSChannelError
1617

1718
from google.api_core import universe
18-
from google.auth.exceptions import MutualTLSChannelError
1919

2020

2121
class _Fake_Credentials:
@@ -114,13 +114,19 @@ def test_get_universe_domain():
114114

115115
def test_get_default_mtls_endpoint():
116116
# Test valid API endpoints
117-
assert universe.get_default_mtls_endpoint("foo.googleapis.com") == "foo.mtls.googleapis.com"
117+
assert (
118+
universe.get_default_mtls_endpoint("foo.googleapis.com")
119+
== "foo.mtls.googleapis.com"
120+
)
118121
assert (
119122
universe.get_default_mtls_endpoint("foo.sandbox.googleapis.com")
120123
== "foo.mtls.sandbox.googleapis.com"
121124
)
122125
# Test case-insensitivity
123-
assert universe.get_default_mtls_endpoint("foo.GoogleAPIs.com") == "foo.mtls.googleapis.com"
126+
assert (
127+
universe.get_default_mtls_endpoint("foo.GoogleAPIs.com")
128+
== "foo.mtls.googleapis.com"
129+
)
124130
assert (
125131
universe.get_default_mtls_endpoint("foo.Sandbox.GoogleAPIs.com")
126132
== "foo.mtls.sandbox.googleapis.com"
@@ -167,6 +173,10 @@ def test_get_default_mtls_endpoint():
167173
assert universe.get_default_mtls_endpoint("") == ""
168174
assert universe.get_default_mtls_endpoint(None) is None
169175

176+
# Test endpoints without host
177+
assert universe.get_default_mtls_endpoint("http://") == "http://"
178+
assert universe.get_default_mtls_endpoint("https://") == "https://"
179+
170180

171181
@pytest.mark.parametrize(
172182
"api_override,universe_domain,default_universe,default_mtls_endpoint,default_endpoint_template,use_mtls,expected",
@@ -249,4 +259,3 @@ def test_get_api_endpoint(
249259
)
250260
== expected
251261
)
252-

0 commit comments

Comments
 (0)