fix: make test_utils unique_resource_id parallel-safe (#17440)

This PR shifts the parallel-safety logic (`os.getpid()`) out of the
individual firestore system tests, baking it directly into the shared
`test_utils` package.

This ensures that all packages in the monorepo using pytest-xdist will
automatically generate unique collection/resource names that never
collide across parallel workers, rather than requiring each library to
manually append PID strings to `unique_resource_id()`.

Author: ohmayr

.librarian/generator-input/client-post-processing/firestore-integration.yaml

@@ -564,6 +564,31 @@ replacements:
           "freezegun",
       ]
     count: 1
+  - paths: [
+      packages/google-cloud-firestore/noxfile.py
+    ]
+    before: |
+      SYSTEM_TEST_STANDARD_DEPENDENCIES = \[
+          "mock",
+          "pytest",
+          "google-cloud-testutils",
+      \]
+    after: |
+      SYSTEM_TEST_STANDARD_DEPENDENCIES = [
+          "mock",
+          "pytest",
+      ]
+    count: 1
+  - paths: [
+      packages/google-cloud-firestore/noxfile.py
+    ]
+    before: |
+      SYSTEM_TEST_LOCAL_DEPENDENCIES: List\[str\] = \[\]
+    after: |
+      SYSTEM_TEST_LOCAL_DEPENDENCIES: List[str] = [
+          "../google-cloud-testutils"
+      ]
+    count: 1
   # TODO(https://github.com/googleapis/google-cloud-python/issues/17429):
   # Temporary post-processing rule to add pytest-xdist dependency.
   # Remove this once gapic-generator includes pytest-xdist by default.

packages/google-cloud-firestore/noxfile.py

@@ -76,15 +76,14 @@
 SYSTEM_TEST_STANDARD_DEPENDENCIES = [
     "mock",
     "pytest",
-    "google-cloud-testutils",
 ]
 SYSTEM_TEST_EXTERNAL_DEPENDENCIES: List[str] = [
     "pytest-asyncio==0.21.2",
     "six",
     "pyyaml",
     "pytest-xdist",
 ]
-SYSTEM_TEST_LOCAL_DEPENDENCIES: List[str] = []
+SYSTEM_TEST_LOCAL_DEPENDENCIES: List[str] = ["../google-cloud-testutils"]
 SYSTEM_TEST_DEPENDENCIES: List[str] = []
 SYSTEM_TEST_EXTRAS: List[str] = []
 SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}

packages/google-cloud-firestore/tests/system/test__helpers.py

@@ -16,7 +16,7 @@
 MISSING_DOCUMENT = "No document to update: "
 DOCUMENT_EXISTS = "Document already exists: "
 ENTERPRISE_MODE_ERROR = "only allowed on ENTERPRISE mode"
-UNIQUE_RESOURCE_ID = unique_resource_id("-") + "-" + str(os.getpid())
+UNIQUE_RESOURCE_ID = unique_resource_id("-")
 EMULATOR_CREDS = EmulatorCreds()
 FIRESTORE_EMULATOR = os.environ.get(_FIRESTORE_EMULATOR_HOST) is not None
 FIRESTORE_OTHER_DB = os.environ.get("SYSTEM_TESTS_DATABASE", "system-tests-named-db")

packages/google-cloud-testutils/test_utils/system.py

@@ -74,7 +74,15 @@ def unique_resource_id(delimiter="_"):
     testing environments and at particular times.
     """
     build_id = os.getenv("CIRCLE_BUILD_NUM", "")
+    pid = os.getpid()
     if build_id == "":
-        return "%s%d" % (delimiter, 1000 * time.time())
+        return "%s%d%s%d" % (delimiter, 1000 * time.time(), delimiter, pid)
     else:
-        return "%s%s%s%d" % (delimiter, build_id, delimiter, time.time())
+        return "%s%s%s%d%s%d" % (
+            delimiter,
+            build_id,
+            delimiter,
+            time.time(),
+            delimiter,
+            pid,
+        )