address feedback

Author: parthea

packages/gapic-generator/repositories.bzl

@@ -16,6 +16,9 @@ def gapic_generator_python():
         urls = ["https://github.com/bazelbuild/bazel-skylib/archive/2169ae1c374aab4a09aa90e65efe1a3aad4e279b.tar.gz"],
     )
 
+    # Load gRPC v1.83.0 with temporary patch for legacy_channel.cc.
+    # The fix is merged upstream (https://github.com/grpc/grpc/commit/816506e5c0434a42414af6955cc9eef0c562ff3a)
+    # and this patch is temporary until released in a future gRPC release.
     _grpc_version = "1.83.0"
     _grpc_sha256 = "876ff5c9c26f364cd603531761268a5b58ccc1479afc78d6dab1d8e839da00c0"
     _maybe(
@@ -24,6 +27,9 @@ def gapic_generator_python():
         sha256 = _grpc_sha256,
         strip_prefix = "grpc-{}".format(_grpc_version),
         url = "https://github.com/grpc/grpc/archive/v{}.zip".format(_grpc_version),
+        patch_cmds = [
+            "python3 -c \"f='src/core/lib/surface/legacy_channel.cc'; c=open(f).read(); open(f,'w').write(c.replace('args.arena_init_function = arena_init_function;', 'if (arena_init_function.has_value()) { args.arena_init_function.emplace(*arena_init_function); }')) if 'args.arena_init_function = arena_init_function;' in c else None\""
+        ],
     )
 
     _maybe(

packages/gapic-generator/rules_python_gapic/py_gapic.bzl

@@ -80,7 +80,7 @@ def py_gapic_library(
     # to convert modern Starlark ProtoInfo into rules_gapic's expected CustomProtoInfo.
     # We extract and propagate 'testonly' from kwargs to prevent Bazel dependency analysis
     # errors when py_gapic_library or its input proto targets are marked testonly = True.
-    testonly = kwargs.get("testonly", None)
+    testonly = kwargs.get("testonly", False)
     compat_srcs = []
     for i, src in enumerate(srcs):
         compat_name = "%s_compat_src_%d" % (name, i)