removed parent and reference_slice

Author: daniel-sanche

packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py

@@ -1149,19 +1149,6 @@ def switch_on(
         )
         return FunctionExpression("switch_on", args)
 
-    @expose_as_static
-    def parent(self) -> "Expression":
-        """Creates an expression that returns the parent document of a document reference.
-
-        Example:
-            >>> # Get the parent document of a document reference.
-            >>> Field.of("__name__").parent()
-
-        Returns:
-            An Expression representing that returns a reference to the parent document.
-        """
-        return FunctionExpression("parent", [self])
-
     @expose_as_static
     def storage_size(self) -> "Expression":
         """Calculates the Firestore storage size of a given value.
@@ -1176,29 +1163,6 @@ def storage_size(self) -> "Expression":
         """
         return FunctionExpression("storage_size", [self])
 
-    @expose_as_static
-    def reference_slice(
-        self, offset: int | Expression, length: int | Expression
-    ) -> "Expression":
-        """Extracts a slice of the path segments from a document reference.
-
-        Example:
-            >>> Field.of("__name__").reference_slice(1, 2)
-
-        Args:
-            offset: The starting index of the path segment.
-            length: The number of segments to include in the slice.
-
-        Returns:
-            A new `Expression` that returns a reference to the sliced portion of the document path.
-        """
-        args = [
-            self,
-            self._cast_to_expr_or_convert_to_constant(offset),
-            self._cast_to_expr_or_convert_to_constant(length),
-        ]
-        return FunctionExpression("reference_slice", args)
-
     @expose_as_static
     def sum(self) -> "Expression":
         """Creates an aggregation that calculates the sum of a numeric field across multiple stage inputs.

packages/google-cloud-firestore/tests/system/pipeline_e2e/general.yaml

@@ -295,53 +295,6 @@ tests:
         - Pipeline:
           - Collection: books
     assert_count: 20 # Results will be duplicated
-  - description: testDocumentId
-    pipeline:
-      - Collection: books
-      - Where:
-          - FunctionExpression.equal:
-              - Field: title
-              - Constant: "The Hitchhiker's Guide to the Galaxy"
-      - Select:
-        - AliasedExpression:
-            - FunctionExpression.document_id:
-                - Field: __name__
-            - "doc_id"
-    assert_results:
-      - doc_id: "book1"
-    assert_proto:
-      pipeline:
-        stages:
-        - args:
-          - referenceValue: /books
-          name: collection
-        - args:
-          - functionValue:
-              args:
-              - fieldReferenceValue: title
-              - stringValue: "The Hitchhiker's Guide to the Galaxy"
-              name: equal
-          name: where
-        - args:
-          - mapValue:
-              fields:
-                doc_id:
-                  functionValue:
-                    name: document_id
-                    args:
-                    - fieldReferenceValue: __name__
-          name: select
-  - description: testCollectionId
-    pipeline:
-      - Collection: books
-      - Limit: 1
-      - Select:
-        - AliasedExpression:
-            - FunctionExpression.collection_id:
-                - Field: __name__
-            - "collectionName"
-    assert_results:
-      - collectionName: "books"
   - description: testCollectionGroup
     pipeline:
       - CollectionGroup: books
@@ -794,35 +747,6 @@ tests:
         - res
     assert_results:
       - res: "B"
-  - description: testParent
-    pipeline:
-      - Collection: books
-      - Limit: 1
-      - Select:
-        - AliasedExpression:
-            - FunctionExpression.parent:
-                - Field: __name__
-            - res
-    assert_results:
-      - res: "/books/book1"
-    assert_proto:
-      pipeline:
-        stages:
-        - args:
-          - referenceValue: /books
-          name: collection
-        - args:
-          - integerValue: '1'
-          name: limit
-        - args:
-          - mapValue:
-              fields:
-                res:
-                  functionValue:
-                    args:
-                    - fieldReferenceValue: __name__
-                    name: parent
-          name: select
   - description: testStorageSize
     pipeline:
       - Collection: books
@@ -852,47 +776,3 @@ tests:
                     - fieldReferenceValue: __name__
                     name: storage_size
           name: select
-  - description: testReferenceSlice
-    pipeline:
-      - Collection: books
-      - Where:
-          - FunctionExpression.equal:
-              - Field: title
-              - Constant: "1984"
-      - Select:
-        - AliasedExpression:
-            - FunctionExpression.document_id:
-                - FunctionExpression.reference_slice:
-                    - Field: __name__
-                    - Constant: 0
-                    - Constant: 1
-            - res
-    assert_results:
-      - res: "book8"
-    assert_proto:
-      pipeline:
-        stages:
-        - args:
-          - referenceValue: /books
-          name: collection
-        - args:
-          - functionValue:
-              args:
-              - fieldReferenceValue: title
-              - stringValue: '1984'
-              name: equal
-          name: where
-        - args:
-          - mapValue:
-              fields:
-                res:
-                  functionValue:
-                    args:
-                    - functionValue:
-                        args:
-                        - fieldReferenceValue: __name__
-                        - integerValue: '0'
-                        - integerValue: '1'
-                        name: reference_slice
-                    name: document_id
-          name: select

packages/google-cloud-firestore/tests/system/pipeline_e2e/references.yaml

@@ -0,0 +1,49 @@
+tests:
+  - description: testDocumentId
+    pipeline:
+      - Collection: books
+      - Where:
+          - FunctionExpression.equal:
+              - Field: title
+              - Constant: "The Hitchhiker's Guide to the Galaxy"
+      - Select:
+        - AliasedExpression:
+            - FunctionExpression.document_id:
+                - Field: __name__
+            - "doc_id"
+    assert_results:
+      - doc_id: "book1"
+    assert_proto:
+      pipeline:
+        stages:
+        - args:
+          - referenceValue: /books
+          name: collection
+        - args:
+          - functionValue:
+              args:
+              - fieldReferenceValue: title
+              - stringValue: "The Hitchhiker's Guide to the Galaxy"
+              name: equal
+          name: where
+        - args:
+          - mapValue:
+              fields:
+                doc_id:
+                  functionValue:
+                    name: document_id
+                    args:
+                    - fieldReferenceValue: __name__
+          name: select
+  - description: testCollectionId
+    pipeline:
+      - Collection: books
+      - Limit: 1
+      - Select:
+        - AliasedExpression:
+            - FunctionExpression.collection_id:
+                - Field: __name__
+            - "collectionName"
+    assert_results:
+      - collectionName: "books"
+

packages/google-cloud-firestore/tests/unit/v1/test_pipeline_expressions.py

@@ -949,15 +949,6 @@ def test_switch_on(self):
         infix_instance = arg1.switch_on(arg2, arg3, arg4, arg5)
         assert infix_instance == instance
 
-    def test_parent(self):
-        arg1 = self._make_arg("Input")
-        instance = Expression.parent(arg1)
-        assert instance.name == "parent"
-        assert instance.params == [arg1]
-        assert repr(instance) == "Input.parent()"
-        infix_instance = arg1.parent()
-        assert infix_instance == instance
-
     def test_storage_size(self):
         arg1 = self._make_arg("Input")
         instance = Expression.storage_size(arg1)
@@ -967,17 +958,6 @@ def test_storage_size(self):
         infix_instance = arg1.storage_size()
         assert infix_instance == instance
 
-    def test_reference_slice(self):
-        arg1 = self._make_arg("Input")
-        arg2 = self._make_arg("Offset")
-        arg3 = self._make_arg("Length")
-        instance = Expression.reference_slice(arg1, arg2, arg3)
-        assert instance.name == "reference_slice"
-        assert instance.params == [arg1, arg2, arg3]
-        assert repr(instance) == "Input.reference_slice(Offset, Length)"
-        infix_instance = arg1.reference_slice(arg2, arg3)
-        assert infix_instance == instance
-
     def test_not(self):
         arg1 = self._make_arg("Condition")
         instance = expr.Not(arg1)