Skip to content

Commit c5c6806

Browse files
committed
test(api-core): align bound field test function names with reviewer feedback
1 parent fdb83f7 commit c5c6806

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/google-api-core/google/api_core/rest_helpers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import functools
1818
import operator
19-
import re
2019
from typing import Any, Dict, List, Optional, Tuple
2120

2221
from google.api_core import path_template

packages/google-api-core/tests/unit/test_rest_helpers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def test_transcode_request_proto_plus_wrapper():
278278
assert transcoded["uri"] == "/v1/test/proto-plus-field"
279279

280280

281-
def test_transcode_required_fields_bound_to_path():
281+
def test_transcode_with_required_fields_in_path():
282282
http_options = [{"method": "get", "uri": "/v1/test/{name}"}]
283283
request = descriptor_pb2.FieldDescriptorProto()
284284
request.name = "my-name"
@@ -293,7 +293,7 @@ def test_transcode_required_fields_bound_to_path():
293293
assert query_params["filter"] == "default-filter"
294294

295295

296-
def test_transcode_required_fields_bound_to_body_star():
296+
def test_transcode_with_required_fields_in_body():
297297
http_options = [{"method": "post", "uri": "/v1/test", "body": "*"}]
298298
request = descriptor_pb2.FieldDescriptorProto()
299299
request.name = "my-name"
@@ -304,4 +304,5 @@ def test_transcode_required_fields_bound_to_body_star():
304304
)
305305

306306
assert body is not None
307+
assert "name" not in query_params
307308
assert query_params == {}

0 commit comments

Comments
 (0)