Skip to content

Commit ca8e302

Browse files
jskeetchalmerlowe
authored andcommitted
chore: complete google-cloud-runtimeconfig migration (#16670)
- Reformat with nox - Enable generation with librarian - Regenerate with librarian
1 parent 09d8e13 commit ca8e302

File tree

11 files changed

+22
-23
lines changed

11 files changed

+22
-23
lines changed

librarian.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3280,7 +3280,6 @@ libraries:
32803280
default_version: v2
32813281
- name: google-cloud-runtimeconfig
32823282
version: 0.36.1
3283-
skip_generate: true
32843283
python:
32853284
library_type: GAPIC_MANUAL
32863285
name_pretty_override: Google Cloud Runtime Configurator
Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
{
2-
"name": "runtimeconfig",
3-
"name_pretty": "Google Cloud Runtime Configurator",
4-
"product_documentation": "https://cloud.google.com/deployment-manager/runtime-configurator/",
2+
"api_id": "runtimeconfig.googleapis.com",
3+
"api_shortname": "runtimeconfig",
54
"client_documentation": "https://cloud.google.com/python/docs/reference/runtimeconfig/latest",
5+
"distribution_name": "google-cloud-runtimeconfig",
66
"issue_tracker": "https://issuetracker.google.com/savedsearches/559663",
7-
"release_level": "preview",
87
"language": "python",
98
"library_type": "GAPIC_MANUAL",
10-
"repo": "googleapis/google-cloud-python",
11-
"distribution_name": "google-cloud-runtimeconfig",
12-
"api_id": "runtimeconfig.googleapis.com",
13-
"requires_billing": true,
14-
"default_version": "",
15-
"codeowner_team": "",
16-
"api_shortname": "runtimeconfig"
17-
}
9+
"name": "runtimeconfig",
10+
"name_pretty": "Google Cloud Runtime Configurator",
11+
"product_documentation": "https://cloud.google.com/deployment-manager/runtime-configurator/",
12+
"release_level": "preview",
13+
"repo": "googleapis/google-cloud-python"
14+
}

packages/google-cloud-runtimeconfig/docs/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
# All configuration values have a default; values that are commented out
2525
# serve to show the default.
2626

27-
import sys
2827
import os
2928
import shlex
29+
import sys
3030

3131
# If extensions (or modules to document with autodoc) are in another directory,
3232
# add these directories to sys.path here. If the directory is relative to the

packages/google-cloud-runtimeconfig/google/cloud/runtimeconfig/_http.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818

1919
from google.cloud import _http
20-
2120
from google.cloud.runtimeconfig import __version__
2221

2322

packages/google-cloud-runtimeconfig/google/cloud/runtimeconfig/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
from google.api_core import page_iterator
1818
from google.cloud.exceptions import NotFound
19+
1920
from google.cloud.runtimeconfig._helpers import config_name_from_full_name
2021
from google.cloud.runtimeconfig.variable import Variable
2122

packages/google-cloud-runtimeconfig/google/cloud/runtimeconfig/variable.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040

4141
from google.api_core import datetime_helpers
4242
from google.cloud.exceptions import Conflict, NotFound
43+
4344
from google.cloud.runtimeconfig._helpers import variable_name_from_full_name
4445
from google.cloud.runtimeconfig.exceptions import Error
4546

46-
4747
STATE_UNSPECIFIED = "VARIABLE_STATE_UNSPECIFIED"
4848
STATE_UPDATED = "UPDATED"
4949
STATE_DELETED = "DELETED"

packages/google-cloud-runtimeconfig/setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import setuptools
1919

20-
2120
# Package metadata.
2221

2322
name = "google-cloud-runtimeconfig"

packages/google-cloud-runtimeconfig/tests/unit/test__http.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ def test_default_url(self):
3333
self.assertIs(conn._client, client)
3434

3535
def test_build_api_url_no_extra_query_params(self):
36-
from urllib.parse import parse_qsl
37-
from urllib.parse import urlsplit
36+
from urllib.parse import parse_qsl, urlsplit
3837

3938
conn = self._make_one(object())
4039
uri = conn.build_api_url("/foo")
@@ -47,8 +46,7 @@ def test_build_api_url_no_extra_query_params(self):
4746
self.assertEqual(parms, {})
4847

4948
def test_build_api_url_w_custom_endpoint(self):
50-
from urllib.parse import parse_qsl
51-
from urllib.parse import urlsplit
49+
from urllib.parse import parse_qsl, urlsplit
5250

5351
custom_endpoint = "https://foo-runtimeconfig.googleapis.com"
5452
conn = self._make_one(object(), api_endpoint=custom_endpoint)
@@ -62,8 +60,7 @@ def test_build_api_url_w_custom_endpoint(self):
6260
self.assertEqual(parms, {})
6361

6462
def test_build_api_url_w_extra_query_params(self):
65-
from urllib.parse import parse_qsl
66-
from urllib.parse import urlsplit
63+
from urllib.parse import parse_qsl, urlsplit
6764

6865
conn = self._make_one(object())
6966
uri = conn.build_api_url("/foo", {"bar": "baz"})
@@ -75,6 +72,7 @@ def test_build_api_url_w_extra_query_params(self):
7572

7673
def test_extra_headers(self):
7774
import requests
75+
7876
from google.cloud import _http as base_http
7977

8078
http = mock.create_autospec(requests.Session, instance=True)

packages/google-cloud-runtimeconfig/tests/unit/test_client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def _make_one(self, *args, **kw):
3535

3636
def test_ctor_wo_client_info(self):
3737
from google.cloud._http import ClientInfo
38+
3839
from google.cloud.runtimeconfig._http import Connection
3940

4041
project = "PROJECT"
@@ -49,6 +50,7 @@ def test_ctor_wo_client_info(self):
4950

5051
def test_ctor_w_client_info(self):
5152
from google.cloud._http import ClientInfo
53+
5254
from google.cloud.runtimeconfig._http import Connection
5355

5456
project = "PROJECT"

packages/google-cloud-runtimeconfig/tests/unit/test_config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ def test_list_variables_empty(self):
231231

232232
def test_list_variables_defaults(self):
233233
from google.cloud._helpers import _rfc3339_to_datetime
234+
234235
from google.cloud.runtimeconfig.variable import Variable
235236

236237
VARIABLE_1 = "variable-one"
@@ -277,6 +278,7 @@ def test_list_variables_defaults(self):
277278

278279
def test_list_variables_explicit(self):
279280
from google.cloud._helpers import _rfc3339_to_datetime
281+
280282
from google.cloud.runtimeconfig.variable import Variable
281283

282284
VARIABLE_1 = "variable-one"

0 commit comments

Comments
 (0)