Address code review feedback on mTLS refactoring

Author: nbayati

packages/google-auth/google/auth/transport/mtls.py

@@ -139,7 +139,8 @@ def should_use_client_cert():
     bool value will be returned
     If GOOGLE_API_USE_CLIENT_CERTIFICATE is unset, the value will be inferred by
     reading a file pointed at by GOOGLE_API_CERTIFICATE_CONFIG or
-    CLOUDSDK_CONTEXT_AWARE_CERTIFICATE_CONFIG_FILE_PATH, and verifying it
+    CLOUDSDK_CONTEXT_AWARE_CERTIFICATE_CONFIG_FILE_PATH, or the default path
+    like ~/.config/gcloud/certificate_config.json, and verifying it
     contains a "workload" section. If so, the function will return True,
     otherwise False.
 

packages/google-auth/tests/transport/test__mtls_helper.py

@@ -588,10 +588,16 @@ def test_success_with_override(self):
         returned_path = _mtls_helper._get_cert_config_path(config_path)
         assert returned_path == config_path
 
-    def test_override_does_not_exist(self):
+    @mock.patch("google.auth.transport._mtls_helper._LOGGER.debug")
+    def test_override_does_not_exist(self, mock_debug):
         config_path = "fake/file/path"
         returned_path = _mtls_helper._get_cert_config_path(config_path)
         assert returned_path is None
+        mock_debug.assert_called_once_with(
+            "Certificate configuration file explicitly specified via %s at %s does not exist",
+            "function argument",
+            "fake/file/path",
+        )
 
     @mock.patch.dict(
         os.environ,
@@ -878,7 +884,6 @@ def test_config_file_invalid_json_type(self, mock_exists, mock_file):
     @mock.patch.dict(os.environ, {}, clear=True)
     @mock.patch("os.path.exists", autospec=True)
     def test_no_env_vars_set(self, mock_exists, mock_open):
-        _mtls_helper._has_logged_mtls_warning = False
         mock_exists.return_value = False
         mock_open.side_effect = FileNotFoundError()
         assert _mtls_helper.check_use_client_cert() is False

packages/google-auth/tests/transport/test_mtls.py

@@ -51,6 +51,23 @@ def side_effect(path):
     mock_check.assert_any_call(_mtls_helper.CONTEXT_AWARE_METADATA_PATH)
 
 
+@mock.patch("google.auth.transport._mtls_helper._get_cert_config_path")
+@mock.patch("google.auth.transport._mtls_helper._check_config_path")
+def test_has_default_client_cert_source_without_context_aware(
+    mock_check, mock_get_cert
+):
+    """
+    Tests that if include_context_aware is False, it skips checking CONTEXT_AWARE_METADATA_PATH.
+    """
+    mock_get_cert.return_value = None
+
+    result = mtls.has_default_client_cert_source(include_context_aware=False)
+
+    assert result is False
+    mock_get_cert.assert_called_once_with(include_context_aware=False)
+    mock_check.assert_not_called()
+
+
 @mock.patch("google.auth.transport._mtls_helper._check_config_path")
 @mock.patch("google.auth.transport._mtls_helper._get_cert_config_path")
 def test_has_default_client_cert_source_falls_back(mock_get_cert, mock_check):