Skip to content

Commit d272d50

Browse files
authored
chore(api-core): remove dead __contains__ methods from MockRequest (#17796)
### Description This PR addresses code review feedback by removing unused/dead mock helper methods: - Removed `__contains__` methods from `MockRequest` and `MockValueErrorRequest` classes in `test_requests.py`, as the `in` operator is only used on `dict` type checks inside `setup_request_id`.
1 parent 14447fb commit d272d50

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

packages/google-api-core/tests/unit/gapic/test_requests.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ def __init__(self, **kwargs):
2727
for k, v in kwargs.items():
2828
setattr(self, k, v)
2929

30-
def __contains__(self, key):
31-
return hasattr(self, key)
32-
3330

3431
class MockProtoRequest:
3532
def __init__(self, **kwargs):
@@ -44,9 +41,6 @@ class MockValueErrorRequest:
4441
def HasField(self, key):
4542
raise ValueError("Mismatched field")
4643

47-
def __contains__(self, key):
48-
return hasattr(self, key)
49-
5044

5145
# --- Parameterized Test ---
5246

0 commit comments

Comments
 (0)