Skip to content

Commit d307bd8

Browse files
committed
chore(django-spanner): stabilize Django 5.2 system tests and remove obsolete workflows
1 parent c54a68d commit d307bd8

File tree

7 files changed

+415
-126
lines changed

7 files changed

+415
-126
lines changed

.github/workflows/django-spanner-integration-tests-against-emulator-3.8.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

.github/workflows/django-spanner-integration-tests-against-emulator-3.9.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

packages/django-google-spanner/django_spanner/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def instance(self):
132132

133133
if _SPANNER_CLIENT_CACHE is None:
134134
_SPANNER_CLIENT_CACHE = spanner.Client(
135-
project=os.environ["GOOGLE_CLOUD_PROJECT"]
135+
project=os.environ.get("GOOGLE_CLOUD_PROJECT") or self.settings_dict.get("project") or self.settings_dict.get("PROJECT") or "test-project"
136136
)
137137

138138
return _SPANNER_CLIENT_CACHE.instance(self.settings_dict["INSTANCE"])
@@ -155,7 +155,7 @@ def get_connection_params(self):
155155
in Django Spanner format.
156156
"""
157157
return {
158-
"project": os.environ["GOOGLE_CLOUD_PROJECT"],
158+
"project": os.environ.get("GOOGLE_CLOUD_PROJECT") or self.settings_dict.get("project") or self.settings_dict.get("PROJECT") or "test-project",
159159
"instance_id": self.settings_dict["INSTANCE"],
160160
"database_id": self.settings_dict["NAME"],
161161
"user_agent": "django_spanner/2.2.0a1",

0 commit comments

Comments
 (0)