Skip to content

Commit d89b672

Browse files
committed
test: cleanup redundant mock setups in test_async_multi_range_downloader.py
1 parent 7bcb1cf commit d89b672

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

packages/google-cloud-storage/tests/unit/asyncio/test_async_multi_range_downloader.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ async def _make_mock_mrd(
6060
mock_stream.generation_number = _TEST_GENERATION_NUMBER
6161
mock_stream.persisted_size = _TEST_OBJECT_SIZE
6262
mock_stream.read_handle = _TEST_READ_HANDLE
63-
mock_stream.is_stream_open = True
64-
# Default recv blocks forever (tests override with specific side_effect)
65-
mock_stream.recv = AsyncMock(side_effect=asyncio.Event().wait)
6663

6764
mrd = await AsyncMultiRangeDownloader.create_mrd(
6865
mock_client, bucket_name, object_name, generation, read_handle
@@ -422,8 +419,6 @@ async def test_create_mrd_with_generation_number(
422419
mock_stream.generation_number = _TEST_GENERATION_NUMBER
423420
mock_stream.persisted_size = _TEST_OBJECT_SIZE
424421
mock_stream.read_handle = _TEST_READ_HANDLE
425-
mock_stream.is_stream_open = True
426-
mock_stream.recv = AsyncMock(side_effect=asyncio.Event().wait)
427422

428423
# Act
429424
mrd = await AsyncMultiRangeDownloader.create_mrd(
@@ -561,7 +556,6 @@ async def staged_recv():
561556
return None
562557

563558
mock_mrd.read_obj_str.recv = AsyncMock(side_effect=staged_recv)
564-
mock_mrd.read_obj_str.is_stream_open = True
565559

566560
mock_random_int.return_value = 123
567561

0 commit comments

Comments
 (0)