cleanup

Author: TrevorBergeron

packages/bigframes/bigframes/functions/_function_session.py

@@ -854,11 +854,11 @@ def wrapper(func):
                 msg = bfe.format_message("input_types=Series is in preview.")
                 warnings.warn(msg, stacklevel=1, category=bfe.PreviewWarning)
 
-            if not name:  # session-managed resource
+            if not name:  # session-owned resource - will be cleaned up automatically
                 self._update_temp_artifacts(full_rf_name, "")
                 return bq_functions.UdfRoutine(func=func, _udf_def=udf_definition)
 
-            # user-managed permanent resource
+            # user-managed permanent resource - will not be cleaned up automatically
             else:
                 return bq_functions.BigqueryCallableRoutine(
                     udf_definition, session, local_func=func, is_managed=True

packages/bigframes/bigframes/functions/function.py

@@ -17,10 +17,6 @@
 import logging
 from typing import Callable, Optional, Protocol, runtime_checkable, TYPE_CHECKING
 
-if TYPE_CHECKING:
-    from bigframes.session import Session
-    import bigframes.series
-
 import dataclasses
 
 import google.api_core.exceptions
@@ -32,6 +28,8 @@
 
 if TYPE_CHECKING:
     import bigframes.core.col
+    from bigframes.session import Session
+    import bigframes.series
 
 logger = logging.getLogger(__name__)
 
@@ -158,6 +156,12 @@ def read_gbq_function(
 
 @runtime_checkable
 class Udf(Protocol):
+    """
+    Protocol for all BigFrames user-defined functions.
+
+    Has @runtime_checkable so functions like df.apply() can dispatch UDFs with isinstance() checks.
+    """
+
     @property
     def udf_def(self) -> udf_def.BigqueryUdf: ...
 

packages/bigframes/bigframes/functions/function_template.py

@@ -43,7 +43,7 @@ def convert_from_bq_json(type_, arg):
     import base64
     import collections
 
-    converters = collections.defaultdict(lambda: (lambda value: value))  # type: ignore
+    converters = collections.defaultdict(lambda: lambda value: value)  # type: ignore
     converters["BYTES"] = base64.b64decode
     converter = converters[type_]
     return converter(arg) if arg is not None else None
@@ -53,7 +53,7 @@ def convert_to_bq_json(type_, arg):
     import base64
     import collections
 
-    converters = collections.defaultdict(lambda: (lambda value: value))  # type: ignore
+    converters = collections.defaultdict(lambda: lambda value: value)  # type: ignore
     converters["BYTES"] = lambda value: base64.b64encode(value).decode("utf-8")
     converter = converters[type_]
     return converter(arg) if arg is not None else None