chore: updates run_doctest script for clarity, and cleaner BASH

Author: chalmerlowe

packages/bigframes/scripts/run_doctest.sh

@@ -1,7 +1,4 @@
 #!/bin/bash
-# `-e` enables the script to automatically fail when a command fails
-# `-o pipefail` sets the exit code to non-zero if any command fails,
-# or zero if all commands in the pipeline exit successfully.
 set -eo pipefail
 
 # Disable buffering, so that the logs stream through.
@@ -13,40 +10,35 @@ export PYTHONUNBUFFERED=1
 export PROJECT_ROOT=$(realpath "$(dirname "${BASH_SOURCE[0]}")/../../..")
 cd "$PROJECT_ROOT"
 
-# This is needed in order for `git diff` to succeed
 git config --global --add safe.directory "$(realpath .)"
 
 package_name="bigframes"
 package_path="packages/${package_name}"
-
-# Determine if we should skip based on git diff
 files_to_check="${package_path}"
 
+# Use the IF block to handle the case where KOKORO vars are missing
+# (e.g. local testing)
 if [[ -n "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}" && -n "${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" ]]; then
     echo "checking changes with 'git diff ${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT} -- ${files_to_check}'"
-    set +e
+
     package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- "${files_to_check}" | wc -l)
-    set -e
 else
+    # If not a PR (like a local run or a different CI trigger), 
+    # we treat it as 0 so it falls through to the "continuous" check.
     package_modified=0
 fi
 
+# Check if modified OR if it's a continuous build
 if [[ "${package_modified}" -gt 0 || "$KOKORO_BUILD_ARTIFACTS_SUBDIR" == *"continuous"* ]]; then
     echo "------------------------------------------------------------"
     echo "Running doctest for: ${package_name}"
     echo "------------------------------------------------------------"
 
-    # Ensure credentials are set for system tests in Kokoro
-    if [[ -z "${GOOGLE_APPLICATION_CREDENTIALS}" && -f "${KOKORO_GFILE_DIR}/service-account.json" ]]; then
-        export GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/service-account.json"
-    fi
-
     export GOOGLE_CLOUD_PROJECT="bigframes-testing"
+    export NOX_SESSION=("cleanup" "doctest")
+
     cd "${package_path}"
-    
-    python3 -m nox -s cleanup || echo "Warning: Cleanup session failed, proceeding to doctest."
-    python3 -m nox -s doctest
-    echo "DINOSAURS" 
+    python3 -m nox -s "${nox_sessions[@]}"
 else
     echo "No changes in ${package_name} and not a continuous build, skipping."
-fi
+fi