Skip to content

Commit e9c6265

Browse files
authored
fix(google-auth): add bounds for urllib3 and packaging dependencies (#17647)
1. **`setup.py`**: - Added version bounds for `urllib3` and `packaging` in `urllib3_extra_require`: ```python urllib3_extra_require = [ "urllib3 >= 1.26.15, < 3.0.0", "packaging >= 20.0", ] ``` - Set `requests >= 2.30.0, < 3.0.0` for Python 3.10+ compatibility. - Resolved and removed TODO comment for issue #1739. 2. **`testing/constraints-3.10.txt`**: - Added `requests==2.30.0`, `urllib3==1.26.15`, and `packaging==20.0` to lower-bound CI test constraints. Fixes #15155 🦕
1 parent 6da41e8 commit e9c6265

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

packages/google-auth/setup.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
*cryptography_base_require,
2828
)
2929

30-
requests_extra_require = ["requests >= 2.20.0, < 3.0.0"]
30+
requests_extra_require = ["requests >= 2.30.0, < 3.0.0"]
3131

3232
aiohttp_extra_require = ["aiohttp >= 3.8.0, < 4.0.0", *requests_extra_require]
3333

@@ -37,8 +37,10 @@
3737

3838
enterprise_cert_extra_require = cryptography_base_require
3939

40-
# TODO(https://github.com/googleapis/google-auth-library-python/issues/1739): Add bounds for urllib3 and packaging dependencies.
41-
urllib3_extra_require = ["urllib3", "packaging"]
40+
urllib3_extra_require = [
41+
"urllib3 >= 1.26.15, < 3.0.0",
42+
"packaging >= 20.0",
43+
]
4244

4345
rsa_extra_require = ["rsa>=3.1.4,<5"]
4446

packages/google-auth/testing/constraints-3.10.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ pyasn1-modules==0.2.1
99
setuptools==40.3.0
1010
cryptography==38.0.3
1111
aiohttp==3.8.0
12-
requests==2.20.0
12+
requests==2.30.0
1313
pyjwt==2.0
14-
grpcio==1.59.0
14+
grpcio==1.59.0
15+
urllib3==1.26.15
16+
packaging==20.0

0 commit comments

Comments
 (0)