test(api-core): add branch coverage tests for rest_helpers to achieve 100% total branch coverage

Author: hebaalazzeh

packages/google-api-core/google/api_core/rest_helpers.py

@@ -180,9 +180,7 @@ def transcode_request(
                 assert bound_fields is not None
                 uri_template = matched_option.get("uri", "")
                 for m in path_template._VARIABLE_RE.finditer(uri_template):
-                    name = m.group("name")
-                    if name:
-                        bound_fields.add(name.split(".")[0])
+                    bound_fields.add(m.group("name").split(".")[0])
                 if body_param:
                     bound_fields.add(body_param.split(".")[0])
 

packages/google-api-core/tests/unit/test_rest_helpers.py

@@ -324,3 +324,38 @@ def test_transcode_with_required_fields_in_body_param():
     assert transcoded["uri"] == "/v1/test/my-name"
     assert "options" not in query_params
     assert query_params["filter"] == "default-filter"
+
+
+def test_transcode_required_fields_no_matching_option():
+    http_options = [{"method": "get", "uri": "/v1/test"}]
+    request = descriptor_pb2.FieldDescriptorProto()
+    required_defaults = {"name": "default-name"}
+
+    with mock.patch(
+        "google.api_core.path_template.transcode",
+        return_value={"method": "delete", "uri": "/v1/test"},
+    ):
+        _, _, query_params = transcode_request(
+            http_options, request, required_fields_default_values=required_defaults
+        )
+        assert query_params["name"] == "default-name"
+
+
+def test_transcode_required_fields_uri_mismatch():
+    http_options = [
+        {"method": "get", "uri": "/v1/wrong_path/{name}"},
+        {"method": "get", "uri": "/v1/test/{name}"},
+    ]
+    request = descriptor_pb2.FieldDescriptorProto()
+    request.name = "my-name"
+    required_defaults = {"name": "default-name", "filter": "default-filter"}
+
+    with mock.patch(
+        "google.api_core.path_template.transcode",
+        return_value={"method": "get", "uri": "/v1/test/my-name"},
+    ):
+        transcoded, _, query_params = transcode_request(
+            http_options, request, required_fields_default_values=required_defaults
+        )
+        assert "name" not in query_params
+        assert query_params["filter"] == "default-filter"