linted

Author: TrevorBergeron

packages/bigframes/bigframes/session/__init__.py

@@ -324,7 +324,7 @@ def __init__(
             metrics=self._metrics,
             enable_polars_execution=context.enable_polars_execution,
             publisher=self._publisher,
-            labels=labels,
+            labels=tuple(labels.items()),
         )
 
     def __del__(self):

packages/bigframes/bigframes/session/bq_caching_executor.py

@@ -593,7 +593,7 @@ def _execute_plan_gbq(
         peek: Optional[int] = None,
         cache_spec: Optional[ex_spec.CacheSpec] = None,
         must_create_table: bool = True,
-        extra_labels: Mapping[str, str] = {},
+        extra_labels: tuple[tuple[str, str], ...] = (),
     ) -> executor.ExecuteResult:
         """Just execute whatever plan as is, without further caching or decomposition."""
         # TODO(swast): plumb through the api_name of the user-facing api that

packages/bigframes/bigframes/session/proxy_executor.py

@@ -157,10 +157,10 @@ def cached(
             correlation_id = f"{uuid.uuid1().hex[:12]}"
             try:
                 return self._sqlglot_executor.cached(array_value, config=config)
-            except google.cloud.exceptions.BadRequest as e:
+            except Exception as e:
                 msg = bfe.format_message(
-                    f"Compiler ID {correlation_id}: BadRequest on sqlglot. "
-                    f"Falling back to ibis. Details: {e.message}"
+                    f"Compiler ID {correlation_id}: Exception on sqlglot. "
+                    f"Falling back to ibis. Details: {e}"
                 )
                 warnings.warn(msg, category=UserWarning)
                 return self._ibis_executor.cached(

packages/bigframes/tests/unit/session/test_proxy_executor.py

@@ -112,7 +112,9 @@ def test_execute_stable_routes_to_sqlglot_fallback_to_ibis(mock_executor, monkey
     monkeypatch.setattr(bigframes.options.experiments, "sql_compiler", "stable")
     with mock.patch("uuid.uuid1") as mock_uuid:
         mock_uuid.return_value.hex = "1234567890123456"
-        with pytest.warns(UserWarning, match="BadRequest on sqlglot"):
+        with pytest.warns(
+            UserWarning, match="Compiler ID 123456789012: Exception on sqlglot"
+        ):
             mock_executor.execute(array_value, execution_spec)
 
     execution_spec.add_labels.assert_has_calls(