Skip to content

Commit fbc2b05

Browse files
committed
revert sqlalchemy-bigquery which is causing the system test presbumit to fail
1 parent 4fb5cac commit fbc2b05

4 files changed

Lines changed: 5 additions & 14 deletions

File tree

packages/sqlalchemy-bigquery/setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ def readme():
6161
# See: https://github.com/googleapis/python-bigquery/issues/83 The
6262
# grpc.Channel.close() method isn't added until 1.32.0.
6363
# https://github.com/grpc/grpc/pull/15254
64-
"grpcio >= 1.59.0, < 2.0.0",
64+
"grpcio >= 1.47.0, < 2.0.0",
65+
"grpcio >= 1.49.1, < 2.0.0; python_version =='3.11'",
6566
"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
6667
"pyarrow >= 6.0.0",
6768
],

packages/sqlalchemy-bigquery/testing/constraints-3.10.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ google-auth==2.14.1
99
google-cloud-bigquery==3.20.0
1010
google-cloud-bigquery-storage==2.18.0
1111
google-api-core==2.11.1
12-
grpcio==1.59.0
12+
grpcio==1.47.0
1313
numpy==1.26.4
1414
alembic==1.7.7
1515
pyarrow==6.0.0

packages/sqlalchemy-bigquery/tests/system/test_geography.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ def test_geoalchemy2_core(bigquery_dataset):
3333
3434
- Bigquery doesn't have ST_BUFFER
3535
"""
36-
pytest.skip(
37-
"Test is skipped due to https://github.com/googleapis/google-cloud-python/issues/17287"
38-
)
36+
3937
# Connect to the DB
4038

4139
from sqlalchemy import create_engine
@@ -150,9 +148,7 @@ def test_geoalchemy2_orm(bigquery_dataset):
150148
151149
https://geoalchemy-2.readthedocs.io/en/latest/orm_tutorial.html
152150
"""
153-
pytest.skip(
154-
"Test is skipped due to https://github.com/googleapis/google-cloud-python/issues/17287"
155-
)
151+
156152
# Connect to the DB
157153

158154
from sqlalchemy import create_engine
@@ -265,9 +261,6 @@ class Lake(Base):
265261
# TODO(http://github.com/googleapis/google-cloud-python/issues/17287): Unskip once bug is resolved.
266262
@pytest.mark.skip(reason="Failing in CI with AssertionError.")
267263
def test_geoalchemy2_orm_w_relationship(bigquery_dataset):
268-
pytest.skip(
269-
"Test is skipped due to https://github.com/googleapis/google-cloud-python/issues/17287"
270-
)
271264
from sqlalchemy import create_engine
272265

273266
engine = create_engine(f"bigquery:///{bigquery_dataset}")

packages/sqlalchemy-bigquery/tests/unit/test_geography.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
@pytest.mark.skip(reason="Failing in CI with AssertionError.")
2929
def test_geoalchemy2_core(faux_conn, last_query):
3030
"""Make sure GeoAlchemy 2 Core Tutorial works as adapted to only having geometry"""
31-
pytest.skip(
32-
"Test is skipped due to https://github.com/googleapis/google-cloud-python/issues/17287"
33-
)
3431
conn = faux_conn
3532

3633
# Create the Table

0 commit comments

Comments
 (0)