Skip to content

Commit fbcebd8

Browse files
authored
chore: fix 'multimodel' typo to 'multimodal' (#17038)
Corrects the typo "multimodel" to "multimodal" across the codebase. This includes internal method names, comments, test functions, and GCS paths in system tests. This aligns the naming with the standard term for models supporting multiple data modalities. Fixes #<issue_number_goes_here> 🦕
1 parent 5ca8803 commit fbcebd8

6 files changed

Lines changed: 18 additions & 18 deletions

File tree

packages/bigframes/bigframes/bigquery/_operations/ai.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1205,7 +1205,7 @@ def _convert_series(
12051205
result = convert.to_bf_series(s, default_index=None, session=session)
12061206

12071207
if result.dtype == dtypes.OBJ_REF_DTYPE:
1208-
# Support multimodel
1208+
# Support multimodal
12091209
return result.blob.read_url()
12101210
return result
12111211

packages/bigframes/bigframes/operations/ai.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def map(
223223
bigframes.series.Series,
224224
model.predict(
225225
df,
226-
prompt=self._make_multimodel_prompt(
226+
prompt=self._make_multimodal_prompt(
227227
df, columns, user_instruction, output_instruction
228228
),
229229
temperature=0.0,
@@ -774,7 +774,7 @@ def _attach_embedding(dataframe, source_column: str, embedding_column: str, mode
774774
return result_df
775775

776776
@staticmethod
777-
def _make_multimodel_prompt(
777+
def _make_multimodal_prompt(
778778
prompt_df, columns, user_instruction: str, output_instruction: str
779779
):
780780
prompt = [f"{output_instruction}\n{user_instruction}\nContext: "]

packages/bigframes/bigframes/operations/semantics.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ def filter(self, instruction: str, model, ground_with_google_search: bool = Fals
397397
bigframes.dataframe.DataFrame,
398398
model.predict(
399399
df,
400-
prompt=self._make_multimodel_prompt(
400+
prompt=self._make_multimodal_prompt(
401401
df, columns, user_instruction, output_instruction
402402
),
403403
temperature=0.0,
@@ -518,7 +518,7 @@ def map(
518518
bigframes.series.Series,
519519
model.predict(
520520
df,
521-
prompt=self._make_multimodel_prompt(
521+
prompt=self._make_multimodal_prompt(
522522
df, columns, user_instruction, output_instruction
523523
),
524524
temperature=0.0,
@@ -1094,7 +1094,7 @@ def _attach_embedding(dataframe, source_column: str, embedding_column: str, mode
10941094
return result_df
10951095

10961096
@staticmethod
1097-
def _make_multimodel_prompt(
1097+
def _make_multimodal_prompt(
10981098
prompt_df, columns, user_instruction: str, output_instruction: str
10991099
):
11001100
prompt = [f"{output_instruction}\n{user_instruction}\nContext: "]

packages/bigframes/tests/system/large/operations/test_ai.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_filter_multi_model(session, gemini_flash_model):
6565
10,
6666
):
6767
df = session.from_glob_path(
68-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
68+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
6969
)
7070
df["prey"] = series.Series(
7171
["building", "cross road", "rock", "squirrel", "rabbit"], session=session
@@ -229,7 +229,7 @@ def test_map(session, gemini_flash_model, output_schema, output_col):
229229
)
230230

231231

232-
def test_map_multimodel(session, gemini_flash_model):
232+
def test_map_multimodal(session, gemini_flash_model):
233233
with bigframes.option_context(
234234
AI_OP_EXP_OPTION,
235235
True,
@@ -239,7 +239,7 @@ def test_map_multimodel(session, gemini_flash_model):
239239
10,
240240
):
241241
df = session.from_glob_path(
242-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
242+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
243243
)
244244
df["scenario"] = series.Series(
245245
["building", "cross road", "tree", "squirrel", "rabbit"], session=session

packages/bigframes/tests/system/large/operations/test_semantics.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ def test_filter_multi_model(session, gemini_flash_model):
412412
10,
413413
):
414414
df = session.from_glob_path(
415-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
415+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
416416
)
417417
df["prey"] = series.Series(
418418
["building", "cross road", "rock", "squirrel", "rabbit"], session=session
@@ -571,7 +571,7 @@ def test_map(session, gemini_flash_model):
571571
)
572572

573573

574-
def test_map_multimodel(session, gemini_flash_model):
574+
def test_map_multimodal(session, gemini_flash_model):
575575
with bigframes.option_context(
576576
SEM_OP_EXP_OPTION,
577577
True,
@@ -581,7 +581,7 @@ def test_map_multimodel(session, gemini_flash_model):
581581
10,
582582
):
583583
df = session.from_glob_path(
584-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
584+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
585585
)
586586
df["scenario"] = series.Series(
587587
["building", "cross road", "tree", "squirrel", "rabbit"], session=session

packages/bigframes/tests/system/small/bigquery/test_ai.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def test_ai_generate_bool(session):
160160

161161
def test_ai_generate_bool_multi_model(session):
162162
df = session.from_glob_path(
163-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
163+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
164164
)
165165

166166
result = bbq.ai.generate_bool((df["image"], " contains an animal"))
@@ -197,7 +197,7 @@ def test_ai_generate_int(session):
197197

198198
def test_ai_generate_int_multi_model(session):
199199
df = session.from_glob_path(
200-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
200+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
201201
)
202202

203203
result = bbq.ai.generate_int(
@@ -236,7 +236,7 @@ def test_ai_generate_double(session):
236236

237237
def test_ai_generate_double_multi_model(session):
238238
df = session.from_glob_path(
239-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
239+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
240240
)
241241

242242
result = bbq.ai.generate_double(
@@ -307,7 +307,7 @@ def test_ai_if(session):
307307

308308
def test_ai_if_multi_model(session, bq_connection):
309309
df = session.from_glob_path(
310-
"gs://bigframes-dev-testing/a_multimodel/images/*",
310+
"gs://bigframes-dev-testing/a_multimodal/images/*",
311311
name="image",
312312
connection=bq_connection,
313313
)
@@ -338,7 +338,7 @@ def test_ai_classify_with_examples(session):
338338

339339
def test_ai_classify_multi_model(session, bq_connection):
340340
df = session.from_glob_path(
341-
"gs://bigframes-dev-testing/a_multimodel/images/*",
341+
"gs://bigframes-dev-testing/a_multimodal/images/*",
342342
name="image",
343343
connection=bq_connection,
344344
)
@@ -361,7 +361,7 @@ def test_ai_score(session):
361361

362362
def test_ai_score_multi_model(session):
363363
df = session.from_glob_path(
364-
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
364+
"gs://bigframes-dev-testing/a_multimodal/images/*", name="image"
365365
)
366366
prompt = ("Rank the liveliness of ", df["image"], "on the scale from 1 to 3")
367367

0 commit comments

Comments
 (0)