Skip to content

Commit fc96097

Browse files
feat(storage): support delete_source_objects in compose API
Implements the delete_source_objects parameter in Blob.compose() to allow automatic deletion of source objects upon successful composition. Also adds unit and system tests to verify the new parameter and handles PR feedback. Reference PR: googleapis/google-cloud-java#12873 Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
1 parent a982960 commit fc96097

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

packages/google-cloud-storage/tests/system/test_blob.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -868,13 +868,14 @@ def test_blob_compose_delete_source_objects(shared_bucket, blobs_to_delete):
868868

869869
assert destination.download_as_bytes() == payload_1 + payload_2
870870

871-
if source_1.exists():
872-
blobs_to_delete.append(source_1)
873-
assert not source_1.exists()
874-
875-
if source_2.exists():
876-
blobs_to_delete.append(source_2)
877-
assert not source_2.exists()
871+
try:
872+
assert not source_1.exists()
873+
assert not source_2.exists()
874+
finally:
875+
if source_1.exists():
876+
blobs_to_delete.append(source_1)
877+
if source_2.exists():
878+
blobs_to_delete.append(source_2)
878879

879880

880881
def test_blob_compose_new_blob_wo_content_type(shared_bucket, blobs_to_delete):

0 commit comments

Comments
 (0)