Skip to content

Commit fec974b

Browse files
committed
address feedback
1 parent fc03507 commit fec974b

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

packages/gapic-generator/repositories.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def gapic_generator_python():
2727
sha256 = _grpc_sha256,
2828
strip_prefix = "grpc-{}".format(_grpc_version),
2929
url = "https://github.com/grpc/grpc/archive/v{}.zip".format(_grpc_version),
30-
patches = ["@gapic_generator_python//third_party:grpc_legacy_channel.patch"],
30+
patches = [Label("//third_party:grpc_legacy_channel.patch")],
3131
patch_args = ["-p1"],
3232
)
3333

packages/gapic-generator/rules_python_gapic/py_gapic.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,15 @@ def _gapic_compat_proto_library_impl(ctx):
2727
dep = ctx.attr.dep
2828
starlark_proto = dep[StarlarkProtoInfo]
2929
return [
30+
dep[DefaultInfo],
3031
# Construct CustomProtoInfo provider needed by rules_gapic's proto_custom_library.
3132
# Must not return ProtoInfo here so proto_custom_library selects CustomProtoInfo (which has transitive_imports).
3233
CustomProtoInfo(
3334
direct_sources = starlark_proto.direct_sources,
3435
check_deps_sources = starlark_proto.check_deps_sources,
3536
# Map modern transitive_sources to CustomProtoInfo's transitive_imports field
3637
transitive_imports = starlark_proto.transitive_sources,
37-
)
38+
),
3839
]
3940

4041
gapic_compat_proto_library = rule(

0 commit comments

Comments
 (0)