Skip to content

chore(librarian): onboard google-ads-admanager #14463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 1 commit into from
Sep 18, 2025
Merged

chore(librarian): onboard google-ads-admanager #14463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .librarian/state.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,24 @@ libraries:
remove_regex:
- packages/google-analytics-data
tag_format: '{id}-v{version}'
- id: google-ads-admanager
version: 0.3.0
last_generated_commit: d300b151a973ce0425ae4ad07b3de957ca31bec6
apis:
- path: google/ads/admanager/v1
source_roots:
- packages/google-ads-admanager
preserve_regex:
Copy link
Copy Markdown
Contributor

@jskeet jskeet Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Go, I've made all our regexes anchored to the source directories to avoid any oddities - see https://github.com/googleapis/google-cloud-go/blob/main/.librarian/state.yaml for example.

No need to change this now, but we might want to align on this (and make sure the behavior is really carefully documented). For Go, this fixed issues where there are modules of both "ai" and "aiplatform".

Copy link
Copy Markdown
Contributor Author

@parthea parthea Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #14464

- packages/google-ads-admanager/CHANGELOG.md
- docs/CHANGELOG.md
- docs/README.rst
- samples/README.txt
- tar.gz
- gapic_version.py
- samples/generated_samples/snippet_metadata_
- scripts/client-post-processing
- samples/snippets/README.rst
- tests/system
remove_regex:
- packages/google-ads-admanager
tag_format: '{id}-v{version}'
1 change: 1 addition & 0 deletions scripts/configure_state_yaml/packages_to_onboard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#

packages_to_onboard: [
"google-ads-admanager",
"google-ads-marketingplatform-admin",
"google-ai-generativelanguage",
"google-analytics-admin",
Expand Down
Loading