chore(librarian): anchor regex in state.yaml#14464
Conversation
| - scripts/client-post-processing | ||
| - samples/snippets/README.rst | ||
| - tests/system | ||
| - ^packages/google-cloud-dlp/CHANGELOG.md |
There was a problem hiding this comment.
I'd anchor the end as well as the start, just in case there are leading substrings. (And make it clear where that's intentional.)
It feels possibly over the top, but does avoid any ambiguity.
.librarian/state.yaml
Outdated
| - ^packages/google-cloud-dlp/docs/CHANGELOG.md | ||
| - ^packages/google-cloud-dlp/docs/README.rst | ||
| - ^packages/google-cloud-dlp/samples/README.txt | ||
| - ^packages/google-cloud-dlp/tar.gz |
There was a problem hiding this comment.
Is this right? Wouldn't it be dlp.tar.gz or similar? (It's not clear to me what purpose these files serve, mind you.)
There was a problem hiding this comment.
This is a good call out. This could be fixed but instead I opted to just remove tar.gz from the preserve_regex list. The only reason it was preserved was to reduce the diff however the diff will be minimal if we allow this file to be deleted. This tar file was created by bazel. We're no longer using bazel, so we will only see a diff at the next generation and at onboarding of libraries.
See related fix googleapis/synthtool#2098
There was a problem hiding this comment.
Sounds good. For go, we're making a few one-off changes as part of migration (i.e. at the time of introducing the library into the state file) so that the diff itself from Librarian will be closer to zero. Just something to consider as a migration step - it makes no odds in the long run of course.
There was a problem hiding this comment.
Make sense. I will open a separate PR to remove the existing tar.gz files so that the diff will remain 0
| - samples/snippets/README.rst | ||
| - tests/system | ||
| - ^packages/google-cloud-dlp/CHANGELOG.md | ||
| - ^packages/google-cloud-dlp/docs/CHANGELOG.md |
There was a problem hiding this comment.
Nit: all of the dots in here might be worth escaping. It's unlikely that there'll be a file called packages/google-cloud-dlp/docs/CHANGELOGxmd but at the moment that would match...
|
Closing as per an offline discussion today with @jskeet where we are switching from regex to glob, so polishing the regex is no longer a priority. (See googleapis/librarian#2294) |
2 participants
This PR addresses the feedback from #14463 (comment) to anchor the regex values in
.librarian/state.yaml