chore(librarian): anchor regex in state.yaml #14464
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,18 +9,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-cloud-dlp | ||
| preserve_regex: | ||
| - ^packages/google-cloud-dlp/CHANGELOG.md | ||
| - ^packages/google-cloud-dlp/docs/CHANGELOG.md | ||
|
Contributor
There was a problem hiding this comment. Nit: all of the dots in here might be worth escaping. It's unlikely that there'll be a file called |
||
| - ^packages/google-cloud-dlp/docs/README.rst | ||
| - ^packages/google-cloud-dlp/samples/README.txt | ||
| - ^packages/google-cloud-dlp/tar.gz | ||
|
Contributor
There was a problem hiding this comment. Is this right? Wouldn't it be dlp.tar.gz or similar? (It's not clear to me what purpose these files serve, mind you.)
Contributor
Author
There was a problem hiding this comment. This is a good call out. This could be fixed but instead I opted to just remove See related fix googleapis/synthtool#2098
Contributor
There was a problem hiding this comment. Sounds good. For go, we're making a few one-off changes as part of migration (i.e. at the time of introducing the library into the state file) so that the diff itself from Librarian will be closer to zero. Just something to consider as a migration step - it makes no odds in the long run of course.
Contributor
Author
There was a problem hiding this comment. Make sense. I will open a separate PR to remove the existing tar.gz files so that the diff will remain 0 |
||
| - ^packages/google-cloud-dlp/.*/gapic_version.py | ||
|
parthea marked this conversation as resolved.
|
||
| - ^packages/google-cloud-dlp/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-cloud-dlp/scripts/client-post-processing | ||
| - ^packages/google-cloud-dlp/samples/snippets/README.rst | ||
| - ^packages/google-cloud-dlp/tests/system | ||
| remove_regex: | ||
| - ^packages/google-cloud-dlp | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-cloud-eventarc | ||
| version: 1.15.3 | ||
|
|
@@ -30,18 +30,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-cloud-eventarc | ||
| preserve_regex: | ||
| - ^packages/google-cloud-eventarc/CHANGELOG.md | ||
| - ^packages/google-cloud-eventarc/docs/CHANGELOG.md | ||
| - ^packages/google-cloud-eventarc/docs/README.rst | ||
| - ^packages/google-cloud-eventarc/samples/README.txt | ||
| - ^packages/google-cloud-eventarc/tar.gz | ||
| - ^packages/google-cloud-eventarc/.*/gapic_version.py | ||
| - ^packages/google-cloud-eventarc/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-cloud-eventarc/scripts/client-post-processing | ||
| - ^packages/google-cloud-eventarc/samples/snippets/README.rst | ||
| - ^packages/google-cloud-eventarc/tests/system | ||
| remove_regex: | ||
| - ^packages/google-cloud-eventarc | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-cloud-video-live-stream | ||
| version: 1.12.0 | ||
|
|
@@ -51,18 +51,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-cloud-video-live-stream | ||
| preserve_regex: | ||
| - ^packages/google-cloud-video-live-stream/CHANGELOG.md | ||
| - ^packages/google-cloud-video-live-stream/docs/CHANGELOG.md | ||
| - ^packages/google-cloud-video-live-stream/docs/README.rst | ||
| - ^packages/google-cloud-video-live-stream/samples/README.txt | ||
| - ^packages/google-cloud-video-live-stream/tar.gz | ||
| - ^packages/google-cloud-video-live-stream/.*/gapic_version.py | ||
| - ^packages/google-cloud-video-live-stream/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-cloud-video-live-stream/scripts/client-post-processing | ||
| - ^packages/google-cloud-video-live-stream/samples/snippets/README.rst | ||
| - ^packages/google-cloud-video-live-stream/tests/system | ||
| remove_regex: | ||
| - ^packages/google-cloud-video-live-stream | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-ads-marketingplatform-admin | ||
| version: 0.1.6 | ||
|
|
@@ -72,18 +72,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-ads-marketingplatform-admin | ||
| preserve_regex: | ||
| - ^packages/google-ads-marketingplatform-admin/CHANGELOG.md | ||
| - ^packages/google-ads-marketingplatform-admin/docs/CHANGELOG.md | ||
| - ^packages/google-ads-marketingplatform-admin/docs/README.rst | ||
| - ^packages/google-ads-marketingplatform-admin/samples/README.txt | ||
| - ^packages/google-ads-marketingplatform-admin/tar.gz | ||
| - ^packages/google-ads-marketingplatform-admin/.*/gapic_version.py | ||
| - ^packages/google-ads-marketingplatform-admin/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-ads-marketingplatform-admin/scripts/client-post-processing | ||
| - ^packages/google-ads-marketingplatform-admin/samples/snippets/README.rst | ||
| - ^packages/google-ads-marketingplatform-admin/tests/system | ||
| remove_regex: | ||
| - ^packages/google-ads-marketingplatform-admin | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-ai-generativelanguage | ||
| version: 0.7.0 | ||
|
|
@@ -97,18 +97,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-ai-generativelanguage | ||
| preserve_regex: | ||
| - ^packages/google-ai-generativelanguage/CHANGELOG.md | ||
| - ^packages/google-ai-generativelanguage/docs/CHANGELOG.md | ||
| - ^packages/google-ai-generativelanguage/docs/README.rst | ||
| - ^packages/google-ai-generativelanguage/samples/README.txt | ||
| - ^packages/google-ai-generativelanguage/tar.gz | ||
| - ^packages/google-ai-generativelanguage/.*/gapic_version.py | ||
| - ^packages/google-ai-generativelanguage/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-ai-generativelanguage/scripts/client-post-processing | ||
| - ^packages/google-ai-generativelanguage/samples/snippets/README.rst | ||
| - ^packages/google-ai-generativelanguage/tests/system | ||
| remove_regex: | ||
| - ^packages/google-ai-generativelanguage | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-analytics-admin | ||
| version: 0.25.0 | ||
|
|
@@ -119,18 +119,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-analytics-admin | ||
| preserve_regex: | ||
| - ^packages/google-analytics-admin/CHANGELOG.md | ||
| - ^packages/google-analytics-admin/docs/CHANGELOG.md | ||
| - ^packages/google-analytics-admin/docs/README.rst | ||
| - ^packages/google-analytics-admin/samples/README.txt | ||
| - ^packages/google-analytics-admin/tar.gz | ||
| - ^packages/google-analytics-admin/.*/gapic_version.py | ||
| - ^packages/google-analytics-admin/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-analytics-admin/scripts/client-post-processing | ||
| - ^packages/google-analytics-admin/samples/snippets/README.rst | ||
| - ^packages/google-analytics-admin/tests/system | ||
| remove_regex: | ||
| - ^packages/google-analytics-admin | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-analytics-data | ||
| version: 0.18.19 | ||
|
|
@@ -141,18 +141,18 @@ libraries: | |
| source_roots: | ||
| - packages/google-analytics-data | ||
| preserve_regex: | ||
| - ^packages/google-analytics-data/CHANGELOG.md | ||
| - ^packages/google-analytics-data/docs/CHANGELOG.md | ||
| - ^packages/google-analytics-data/docs/README.rst | ||
| - ^packages/google-analytics-data/samples/README.txt | ||
| - ^packages/google-analytics-data/tar.gz | ||
| - ^packages/google-analytics-data/.*/gapic_version.py | ||
| - ^packages/google-analytics-data/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-analytics-data/scripts/client-post-processing | ||
| - ^packages/google-analytics-data/samples/snippets/README.rst | ||
| - ^packages/google-analytics-data/tests/system | ||
| remove_regex: | ||
| - ^packages/google-analytics-data | ||
| tag_format: '{id}-v{version}' | ||
| - id: google-ads-admanager | ||
| version: 0.3.0 | ||
|
|
@@ -162,16 +162,16 @@ libraries: | |
| source_roots: | ||
| - packages/google-ads-admanager | ||
| preserve_regex: | ||
| - ^packages/google-ads-admanager/CHANGELOG.md | ||
| - ^packages/google-ads-admanager/docs/CHANGELOG.md | ||
| - ^packages/google-ads-admanager/docs/README.rst | ||
| - ^packages/google-ads-admanager/samples/README.txt | ||
| - ^packages/google-ads-admanager/tar.gz | ||
| - ^packages/google-ads-admanager/.*/gapic_version.py | ||
| - ^packages/google-ads-admanager/samples/generated_samples/snippet_metadata_ | ||
| - ^packages/google-ads-admanager/scripts/client-post-processing | ||
| - ^packages/google-ads-admanager/samples/snippets/README.rst | ||
| - ^packages/google-ads-admanager/tests/system | ||
| remove_regex: | ||
| - ^packages/google-ads-admanager | ||
| tag_format: '{id}-v{version}' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd anchor the end as well as the start, just in case there are leading substrings. (And make it clear where that's intentional.)
It feels possibly over the top, but does avoid any ambiguity.