chore: librarian generate pull request: 20250918T173806Z#14465
Closed
cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Closed
chore: librarian generate pull request: 20250918T173806Z#14465cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Conversation
parthea
approved these changes
Sep 18, 2025
parthea
requested changes
Sep 18, 2025
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
packages/google-cloud-video-live-stream/samples/generated_samples/snippet_metadata_google.cloud.video.livestream.v1.json appears in #14453 but is missing in this PR due to the preserve_regex here:
google-cloud-python/.librarian/state.yaml
Lines 53 to 60 in 7926fdd
parthea
added a commit
that referenced
this pull request
Sep 18, 2025
…rom preserve_regex (#14469) This commit fixes a regression where snippet_metadata files, such as `packages/google-cloud-video-live-stream/samples/generated_samples/snippet_metadata_google.cloud.video.livestream.v1.json`, were not being updated during generation (e.g., in PR #14465). The root cause was the inclusion of `samples/generated_samples/snippet_metadata_` in the preserve_regex list. While this regex was initially used to reduce diffs during the transition from OwlBot to Librarian, it inadvertently prevented necessary updates to the generated snippet metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is generated with proto changes between
googleapis/googleapis@f8776fe
(exclusive) and
googleapis/googleapis@36533b0
(inclusive).
Librarian Version: v0.0.0-20250918151329-de628ecd7aa3
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest
BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix: [google-cloud-eventarc] upgrade gRPC service registration func
An update to Go gRPC Protobuf generation will change service registration function signatures to use an interface instead of a concrete type in generated .pb.go service files. This change should affect very few client library users. See release notes advisories in googleapis/google-cloud-go#11025.
PiperOrigin-RevId: 808289479
Source-link: googleapis/googleapis@36533b0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added H.265 (HEVC) codec support
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added UHD (4k) resolution support
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added Auto Transcription support
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added StartDistribution/StopDistribution methods and Distribution/DistributionStream messages used for distributing live streams to external RTMP/SRT endpoints
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added PreviewInput method used for the low latency input monitoring
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-video-live-stream] Added UpdateEncryptions event to perform key rotation without restarting a channel
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: [google-cloud-video-live-stream] Update requirements of resource ID fields to be more clear
PiperOrigin-RevId: 808091810
Source-link: googleapis/googleapis@c4e80cd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [google-cloud-eventarc] add new fields to Eventarc resources
PiperOrigin-RevId: 807339306
Source-link: googleapis/googleapis@dfce92d
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: [google-cloud-eventarc] correct some comments
PiperOrigin-RevId: 807339306
Source-link: googleapis/googleapis@dfce92d
END_NESTED_COMMIT
END_COMMIT_OVERRIDE
Closes #14453
Closes #14439