Skip to content

chore(librarian): Add forward slash to remove regex#14657

Merged
parthea merged 1 commit intomainfrom
add-slash-remove-regex
Oct 6, 2025
Merged

chore(librarian): Add forward slash to remove regex#14657
parthea merged 1 commit intomainfrom
add-slash-remove-regex

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Oct 6, 2025

This PR adds a forward slash to the remove_regex to provide clarity that the regex is for the full directory name not partial name.
For example, for google-cloud-compute , where there also exists google-cloud-compute-v1beta

We would have

    remove_regex:
      - packages/google-cloud-compute/

which would only match google-cloud-compute

instead of

    remove_regex:
      - packages/google-cloud-compute

Which would match both google-cloud-compute and google-cloud-compute-v1beta

@parthea parthea requested a review from a team October 6, 2025 17:07
@parthea parthea requested a review from a team as a code owner October 6, 2025 17:07
@parthea parthea requested a review from quartzmo October 6, 2025 17:07
@parthea parthea merged commit 3cca644 into main Oct 6, 2025
26 checks passed
@parthea parthea deleted the add-slash-remove-regex branch October 6, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants