-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(firestore): pipeline subequeries #16470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniel-sanche
wants to merge
20
commits into
main
Choose a base branch
from
firestore_pipelines_join
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
39abeea
initial commit
daniel-sanche 479d1cd
update docstring
daniel-sanche 351bd02
fixed formatting
daniel-sanche b865156
added assert proto blocks
daniel-sanche 6f37a5b
fixed bug in tests
daniel-sanche d94d967
Apply suggestion from @gemini-code-assist[bot]
daniel-sanche 5666fcb
added get_field
daniel-sanche a08409e
fixed error docstring; added test case
daniel-sanche 15a7789
updated docstrings
daniel-sanche 6c9b65d
added new SubPipeline class
daniel-sanche 604e10d
male SubPipeline public
daniel-sanche 1f9e70c
fixed lint
daniel-sanche 9e4cb07
added e2e test for failed union
daniel-sanche b1f87ef
updating docstrings
daniel-sanche 5a700af
Merge branch 'main' into firestore_pipelines_join
daniel-sanche 6f9d8dd
reordered file
daniel-sanche cc296ac
added test case
daniel-sanche d49efd4
updating test yaml
daniel-sanche 4d58a44
made subcollection into staticmethod
daniel-sanche 6f61f78
added subcollections to test yaml
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being named Subpipeline to avoid name collision ? Is there an existing Subcollection class ?
Java calls this stage Subcollection https://github.com/googleapis/java-firestore/blob/0c8188520dfbada0d3fef0719e4f95fc231306be/google-cloud-firestore/src/main/java/com/google/cloud/firestore/PipelineSource.java#L214-L238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a stage, it's a pipeline subclass. I think this is probably Python-specific, because of the weird way we have to handle async/sync code
In Python, we have 3 classes:
Pipelineto handle sync clientsAsyncPipelineto handle async clients_BasePipelineas a private class to handle common logic between the two.Sub-pipelines presents a new use-case, where neither client is be attached, but it needs to be exposed to end-users
In Java and other implementations, it's much simpler, because there is a single pipeline class, and they just raise an exception if you try to use it to execute on a sub-pipeline.