Skip to content

chore(firestore): skip pipeline verification tests outside enterprise db #16523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 10 commits into from
Apr 7, 2026
Merged

chore(firestore): skip pipeline verification tests outside enterprise db #16523

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
853c825
chore(firestore): skip pipeline verification tests outside enterprise db
daniel-sanche Apr 1, 2026
af55183
added docstring
daniel-sanche Apr 1, 2026
32b4db0
use subtests for verify_pipeline
daniel-sanche Apr 1, 2026
b35f6f1
fixed lint
daniel-sanche Apr 1, 2026
3bd36c9
Update packages/google-cloud-firestore/tests/system/test_system.py
daniel-sanche Apr 7, 2026
5dfca61
added debug logging
daniel-sanche Apr 7, 2026
d1ddc78
add unique component to test
daniel-sanche Apr 7, 2026
6d0300d
Revert "added debug logging"
daniel-sanche Apr 7, 2026
fa046c4
add locks to prevent system test collisions
daniel-sanche Apr 7, 2026
6bb0015
fixed lint
daniel-sanche Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/google-cloud-firestore/tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,13 @@ def verify_pipeline(query):
"""
from google.cloud.firestore_v1.base_aggregation import BaseAggregationQuery

client = query._client
if FIRESTORE_EMULATOR:
pytest.skip("skip pipeline verification on emulator")
print("skip pipeline verification on emulator")
return
if client._database != FIRESTORE_ENTERPRISE_DB:
print("pipelines only supports enterprise db")
return
Comment thread
daniel-sanche marked this conversation as resolved.
Outdated

def _clean_results(results):
if isinstance(results, dict):
Expand Down Expand Up @@ -126,7 +131,6 @@ def _clean_results(results):
except Exception as e:
# if we expect the query to fail, capture the exception
query_exception = e
client = query._client
pipeline = client.pipeline().create_from(query)
if query_exception:
# ensure that the pipeline uses same error as query
Expand Down
8 changes: 6 additions & 2 deletions packages/google-cloud-firestore/tests/system/test_system_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,13 @@ async def verify_pipeline(query):
"""
from google.cloud.firestore_v1.base_aggregation import BaseAggregationQuery

client = query._client
if FIRESTORE_EMULATOR:
pytest.skip("skip pipeline verification on emulator")
print("skip pipeline verification on emulator")
return
if client._database != FIRESTORE_ENTERPRISE_DB:
print("pipelines only supports enterprise db")
return
Comment thread
daniel-sanche marked this conversation as resolved.
Outdated

def _clean_results(results):
if isinstance(results, dict):
Expand Down Expand Up @@ -206,7 +211,6 @@ def _clean_results(results):
except Exception as e:
# if we expect the query to fail, capture the exception
query_exception = e
client = query._client
pipeline = client.pipeline().create_from(query)
if query_exception:
# ensure that the pipeline uses same error as query
Expand Down
Loading