Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds an organization field to the publishing section of the redis_v1.yaml integration test configuration. Feedback indicates that this field may be misplaced within the schema and is located in a section currently marked for future removal.
| # TODO(https://github.com/googleapis/gapic-generator-python/issues/2121): Remove this section | ||
| # when async rest is GA. | ||
| publishing: | ||
| organization: DOES_NOT_EXIST |
Contributor
There was a problem hiding this comment.
The organization field is added to a section marked for removal (see TODO on line 75). Additionally, organization is typically not a valid top-level property under publishing in the GAPIC configuration schema; it usually belongs within language-specific settings (e.g., python_settings). This placement may cause the setting to be ignored or result in validation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.