feat(google-crc32c): add riscv64 manylinux wheel builds#16559
Open
gounthar wants to merge 1 commit intogoogleapis:mainfrom
Open
feat(google-crc32c): add riscv64 manylinux wheel builds#16559gounthar wants to merge 1 commit intogoogleapis:mainfrom
gounthar wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Add riscv64 to the manylinux wheel build matrix using the manylinux_2_39_riscv64 image (the correct tag for riscv64; manylinux2014 has no riscv64 variant). Changes: - scripts/manylinux/build.sh: add riscv64 docker run block - .github/workflows/riscv64-wheels.yml: CI workflow to build and upload riscv64 wheels on pull_request/push to main The build uses QEMU emulation on ubuntu-latest, matching the approach used for the existing aarch64 builds. Follows up on googleapis/python-crc32c#337 (closed when repo was archived; maintainer asked to re-open here). Signed-off-by: Bruno Verachten <gounthar@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for building riscv64 wheels by adding a new GitHub Actions workflow and updating the manylinux build script. Feedback was provided to improve the build script by removing unnecessary Docker flags and redundant pull commands, properly quoting shell variables for robustness, and ensuring the BUILD_PYTHON environment variable is consistently passed in the CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds riscv64 to the manylinux wheel build matrix for
google-crc32c.scripts/manylinux/build.sh: addmanylinux_2_39_riscv64docker run block (the correct manylinux tag for riscv64; manylinux2014 has no riscv64 variant).github/workflows/riscv64-wheels.yml: CI workflow to build and upload riscv64 wheels on pull_request/push to mainThe build uses QEMU emulation on ubuntu-latest, matching the existing approach for aarch64.
This follows up on googleapis/python-crc32c#337, which was closed when that repo was archived. @parthea asked to re-open the PR here.
Test plan
manylinux_2_39_riscv64platform tag