fix: avoid views when querying BigLake tables from SQL cells#16562
fix: avoid views when querying BigLake tables from SQL cells#16562
Conversation
Workaround for internal bug 493608478.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for 4-part BigLake/Iceberg table identifiers by ensuring all parts of the table ID are correctly split and quoted during SQL generation. It also implements a workaround in pyformat.py for BigLake tables, which currently cannot be used in views, by generating a subquery instead of a placeholder table reference. Feedback was provided regarding an inconsistency in index handling for these subqueries compared to other table types.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| import bigframes.core.bq_data as bq_data | ||
| import bigframes.core.nodes as nodes | ||
|
|
||
| # TODO(b/493608478): Remove this workaround for BigLake/Iceberg tables, |
There was a problem hiding this comment.
Should this point to a ticket owned by BigFrames or is it fine to be the root ticket?
There was a problem hiding this comment.
Discussed offline. I haven't seen any automation that would re-open a ticket, so I think this is ok. If that changes, we can file a separate TODO for our cleanup tasks.
2 participants
Workaround for internal bug 493608478.
Migrates googleapis/python-bigquery-dataframes#2545
🦕