chore(bigframes): make tpch golden sql runable#16565
Merged
chelsea-lin merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TPC-H test environment by migrating the target project and dataset to "bigframes-dev-perf.tpch_0001t" and advancing the frozen test time to "2026-04-05". These updates are applied consistently across the test configuration, execution logic, and SQL snapshots. The review feedback suggests centralizing the project/dataset IDs and the frozen timestamp into shared constants to eliminate duplication between the test file and the configuration file, which would improve maintainability.
packages/bigframes/tests/unit/core/compile/sqlglot/tpch/test_tpch.py
Outdated
Show resolved
Hide resolved
chelsea-lin
force-pushed
the
main_chelsealin_tpch
branch
2 times, most recently
from
16a56cd to
4f5d5a5
Compare
chelsea-lin
force-pushed
the
main_chelsealin_tpch
branch
from
4f5d5a5 to
b5c0af1
Compare
sycai
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.