chore(bigframes): update the datetime_ops and isin_join in the sqlglot compiler#16568
Draft
chelsea-lin wants to merge 2 commits intomainfrom
Draft
chore(bigframes): update the datetime_ops and isin_join in the sqlglot compiler#16568chelsea-lin wants to merge 2 commits intomainfrom
chelsea-lin wants to merge 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the PARSE_TIMESTAMP logic with TryCast in datetime operations and optimizes isin_join by utilizing EXISTS instead of IN for multi-column comparisons. A regression was identified in the datetime conversion logic where the op.format parameter is now ignored, which will cause parsing failures for strings that do not follow the default ISO format.
packages/bigframes/bigframes/core/compile/sqlglot/expressions/datetime_ops.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses issues identified during performance testing against Ibis golden SQL.
datetime_ops: Aligned with Ibis behavior by implementing safe parsing instead of throwing errors.isin_join: Improved performance; benchmark details are available here: [screenshot/vmb8ACvJhDNpccp].