Skip to content

chore(spanner): block spanner release#16601

Merged
ohmayr merged 1 commit intomainfrom
block_spanner
Apr 9, 2026
Merged

chore(spanner): block spanner release#16601
ohmayr merged 1 commit intomainfrom
block_spanner

Conversation

@daniel-sanche
Copy link
Copy Markdown
Contributor

Blocks spanner releases due to failing CI

#16600

@daniel-sanche daniel-sanche requested review from a team as code owners April 9, 2026 20:49
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the librarian configuration to block releases for the google-cloud-spanner library, citing an open issue regarding test failures. The review feedback suggests improving the clarity of the documentation comment by focusing on the current blocking action rather than future intentions and adopting a more standard comment format.

Comment on lines +40 to +41
# TODO(https://github.com/googleapis/google-cloud-python/issues/16600):
# Allow release for google-cloud-spanner after tests are fixed.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity, it's better to describe the current action (blocking the release) rather than the future action (allowing the release). This makes it easier to understand the purpose of this configuration at a glance. Also, the TODO(URL) format is unconventional. A more standard comment format would improve readability.

# Block release for google-cloud-spanner due to failing CI tests.
# See: https://github.com/googleapis/google-cloud-python/issues/16600

@ohmayr ohmayr merged commit a58063c into main Apr 9, 2026
31 checks passed
@ohmayr ohmayr deleted the block_spanner branch April 9, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants