Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the librarian configuration to block releases for the google-cloud-spanner library, citing an open issue regarding test failures. The review feedback suggests improving the clarity of the documentation comment by focusing on the current blocking action rather than future intentions and adopting a more standard comment format.
| # TODO(https://github.com/googleapis/google-cloud-python/issues/16600): | ||
| # Allow release for google-cloud-spanner after tests are fixed. |
There was a problem hiding this comment.
For clarity, it's better to describe the current action (blocking the release) rather than the future action (allowing the release). This makes it easier to understand the purpose of this configuration at a glance. Also, the TODO(URL) format is unconventional. A more standard comment format would improve readability.
# Block release for google-cloud-spanner due to failing CI tests.
# See: https://github.com/googleapis/google-cloud-python/issues/16600
Blocks spanner releases due to failing CI
#16600