Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the librarian configuration and updates repository metadata and documentation across a wide range of packages. Feedback identifies critical errors in the repo metadata for certain libraries and a Python syntax error in the django-google-spanner documentation. Additionally, several typos and grammatical mistakes were found in the README files, and a consistent lack of trailing newlines in the metadata files was noted as an area for improvement.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/google-auth/.repo-metadata.json (10)
The repo value seems incorrect. The google-auth library is maintained in the googleapis/google-auth-library-python repository, not googleapis/google-cloud-python. This metadata change could break tooling that relies on it.
"repo": "googleapis/google-auth-library-python"
packages/google-resumable-media/.repo-metadata.json (9)
The repo value seems incorrect. The google-resumable-media library is maintained in the googleapis/google-resumable-media-python repository, not googleapis/google-cloud-python. This metadata change could break tooling that relies on it.
"repo": "googleapis/google-resumable-media-python"
packages/django-google-spanner/docs/README.rst (159)
In Python code, the boolean literal is False, not false. Using false will cause a NameError.
'RANDOM_ID_GENERATION_ENABLED': False,
packages/bigframes/.repo-metadata.json (14)
This file, along with many other .repo-metadata.json files in this PR, is missing a final newline character. It's a common convention to end files with a newline for better processing with command-line tools.
packages/bigframes/docs/README.rst (40)
There's a typo here. enviroment should be environment.
for your local development environment.
packages/django-google-spanner/docs/README.rst (118)
There's a typo here. to installed should be to be installed.
Cloud Spanner database backend, the application needs to be installed and
packages/google-cloud-documentai-toolbox/docs/README.rst (24)
There's a grammatical error here. Since GCS buckets is plural, contains should be contain.
But you must enable the Storage API to access GCS buckets that contain the output of ``BatchProcessDocument()``.
packages/google-cloud-runtimeconfig/docs/README.rst (6)
The description for the Google Cloud Runtime Configurator API link is missing. For consistency with other README files, please add a brief description.
`Google Cloud Runtime Configurator API`_: provides a service for storing and managing configuration data in the Google Cloud Platform.
(This is not expected to be merged)