chore: update googleapis and regenerate#16615
chore: update googleapis and regenerate#16615jskeet wants to merge 6 commits intogoogleapis:mainfrom
Conversation
jskeet
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for DeploymentGroups in the config service, including new API methods, request/response types, and generated samples. The review identified that the generated samples for UpdateDeploymentGroup are currently unusable because they initialize an empty request, which leads to runtime errors due to missing required fields for routing headers. I have provided suggestions to properly initialize these requests in the samples.
| client = config_v1.ConfigAsyncClient() | ||
|
|
||
| # Initialize request argument(s) | ||
| request = config_v1.UpdateDeploymentGroupRequest() |
There was a problem hiding this comment.
Initializing an empty UpdateDeploymentGroupRequest will likely cause a runtime AttributeError because the client code expects request.deployment_group.name to be set for routing headers. The sample is not usable as is. Please update the generator to initialize the request with the required fields.
| request = config_v1.UpdateDeploymentGroupRequest() | |
| deployment_group = config_v1.DeploymentGroup( | |
| name="name_value", | |
| ) | |
| request = config_v1.UpdateDeploymentGroupRequest( | |
| deployment_group=deployment_group, | |
| ) |
| client = config_v1.ConfigClient() | ||
|
|
||
| # Initialize request argument(s) | ||
| request = config_v1.UpdateDeploymentGroupRequest() |
There was a problem hiding this comment.
Initializing an empty UpdateDeploymentGroupRequest will likely cause a runtime AttributeError because the client code expects request.deployment_group.name to be set for routing headers. The sample is not usable as is. Please update the generator to initialize the request with the required fields.
| request = config_v1.UpdateDeploymentGroupRequest() | |
| deployment_group = config_v1.DeploymentGroup( | |
| name="name_value", | |
| ) | |
| request = config_v1.UpdateDeploymentGroupRequest( | |
| deployment_group=deployment_group, | |
| ) |
1 participant
Update googleapis to the latest commit and regenerate all client libraries.
This was a test run of "update and regenerate" before migrating other libraries. We will close this PR.