Conversation
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos. BEGIN_COMMIT BEGIN_NESTED_COMMIT feat: Add `Engine` field to support LightningEngine in clusters and add support for stop ttl PiperOrigin-RevId: 897294662 Library-IDs: google-cloud-dataproc Source-link: [googleapis/googleapis@2da86587](googleapis/googleapis@2da86587) END_NESTED_COMMIT END_COMMIT This pull request is generated with proto changes between [googleapis/googleapis@1133adb1](googleapis/googleapis@1133adb) (exclusive) and [googleapis/googleapis@2da86587](googleapis/googleapis@2da8658) (inclusive). Librarian Version: v1.0.2-0.20260325150042-e450f8f7dcab Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
|
Internal bug: b/502199980 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dataproc v1 library to include new cluster configuration options, specifically adding an engine field to ClusterConfig and auto-stop lifecycle settings (idle_stop_ttl, auto_stop_time, and auto_stop_ttl) to LifecycleConfig. Unit tests have been updated accordingly. A review comment identifies a docstring inconsistency in the Engine enum where a reference to ENGINE_DEFAULT should be corrected to DEFAULT to match the actual enum member name.
| Values: | ||
| ENGINE_UNSPECIFIED (0): | ||
| The engine is not specified. Works the same as | ||
| ENGINE_DEFAULT. |
There was a problem hiding this comment.
The docstring for ENGINE_UNSPECIFIED refers to ENGINE_DEFAULT, but the corresponding enum member is named DEFAULT (line 319). This inconsistency in the documentation should be corrected to refer to the actual member name.
| ENGINE_DEFAULT. | |
| DEFAULT. |
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Add
Enginefield to support LightningEngine in clusters and add support for stop ttlPiperOrigin-RevId: 897294662
Library-IDs: google-cloud-dataproc
Source-link: googleapis/googleapis@2da86587
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
https://github.com/googleapis/googleapis/commit/1133adb1
(exclusive) and
https://github.com/googleapis/googleapis/commit/2da86587
(inclusive).
Librarian Version: v1.0.2-0.20260325150042-e450f8f7dcab
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e