feat: enable mypy session for db-dtypes#16689
Merged
chalmerlowe merged 7 commits intomainfrom Apr 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables mypy type checking by adding a dedicated nox session and applying type suppression comments across the codebase. The review feedback highlights several areas where type safety can be improved beyond simple suppression, such as correctly initializing the base class in core.py, declaring internal methods as class attributes, and fixing an invalid type hint for na_value. It is also suggested to remove the broad --ignore-missing-imports flag from the mypy configuration to avoid masking potential environment issues.
Giving pd.NAType a try instead of Any to see if that passes. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
segregated the steps associated with assigning values to NDArrayBackedExtensionArray versus PandasObject/ExtensionArray to improve clarity and avoid a mypy type hinting issue.
chalmerlowe
commented
Apr 17, 2026
indents function definition.
Attempting to assign values to the attributes directly resulted in write errors.
chalmerlowe
force-pushed
the
feat-enable-mypy-db-dtypes
branch
from
2222ee9 to
c5b6937
Compare
parthea
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the mypy session in noxfile.py for db-dtypes and aligns it with the GAPIC generator template. It passes with some type ignores added for missing stubs and internal pandas usage.