chore: complete migration of google-cloud-monitoring-dashboards#16692
Merged
jskeet merged 4 commits intogoogleapis:mainfrom Apr 16, 2026
Merged
chore: complete migration of google-cloud-monitoring-dashboards#16692jskeet merged 4 commits intogoogleapis:mainfrom
jskeet merged 4 commits intogoogleapis:mainfrom
Conversation
Also remove redundant keep list for code that isn't generated (so won't be cleaned anyway).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the configuration for the google-cloud-monitoring-dashboards library to enable automated generation. Key changes include removing a large list of manually preserved files from librarian.yaml, disabling the skip_generate flag, and adding a post-processing rule to maintain documentation compatibility by updating paths in index.rst. Additionally, the repository metadata was updated to remove the billing requirement and adjust formatting. I have no feedback to provide.
parthea
approved these changes
Apr 16, 2026
chalmerlowe
pushed a commit
that referenced
this pull request
Apr 17, 2026
This requires a new string replacement to avoid a diff in docs/index.rst. (When we audit all the post-processing later, we may decide that the diff is actually beneficial; that's outside the scope of migration.) Fixes googleapis/librarian#5339 Note that this has an approach of "minimal diff" - #11858 suggests that we remove a stale directory, and we can do that separately from the migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires a new string replacement to avoid a diff in docs/index.rst. (When we audit all the post-processing later, we may decide that the diff is actually beneficial; that's outside the scope of migration.)
Fixes googleapis/librarian#5339
Note that this has an approach of "minimal diff" - #11858 suggests that we remove a stale directory, and we can do that separately from the migration.