Skip to content

chore: complete migration of pandas-gbq#16707

Draft
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-pandas-gbq
Draft

chore: complete migration of pandas-gbq#16707
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-pandas-gbq

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 17, 2026

Removed skip_generate and regenerated with Librarian.

@jskeet
chore: complete migration of pandas-gbq
d2a2298 
Removed skip_generate and regenerated with Librarian.
@jskeet jskeet requested review from a team as code owners April 17, 2026 05:44
@jskeet jskeet requested review from TrevorBergeron and removed request for a team April 17, 2026 05:44
gemini-code-assist[bot]
gemini-code-assist bot reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables generation for the pandas-gbq library by removing the skip_generate flag in librarian.yaml and updates the .repo-metadata.json file with alphabetically sorted keys. Feedback indicates that the codeowner_team field was removed during the metadata update and should be restored to maintain automation for PR assignments.

Comment thread packages/pandas-gbq/.repo-metadata.json
@chalmerlowe
Copy link
Copy Markdown
Contributor

chalmerlowe commented Apr 17, 2026

@jskeet I don't yet know what the cause is, but for the life of me, I could not get the pandas-gbq prerelease to complete in one of my PRs. The logs die part way through the run, so I was never able to see what the cause was.

I looked at your logs for unittest/prerelease and they are identical to what I was seeing in other PRs. If I find a solution I will let you know.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 17, 2026

Switching to draft until checks are green

@parthea parthea marked this pull request as draft April 17, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/bigquery-dataframe-team

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jskeet @chalmerlowe @parthea