chore: complete migration of pandas-gbq#16739
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables code generation for the pandas-gbq library by removing the skip_generate flag and reorders the metadata keys in its repository configuration. A review comment correctly identifies that the codeowner_team field was accidentally removed during the reordering process and provides a suggestion to restore it.
| { | ||
| "name": "pandas-gbq", | ||
| "name_pretty": "Google BigQuery connector for pandas", | ||
| "product_documentation": "https://cloud.google.com/bigquery", | ||
| "api_id": "bigquery.googleapis.com", | ||
| "client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/", | ||
| "distribution_name": "pandas-gbq", | ||
| "issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues", | ||
| "release_level": "preview", | ||
| "language": "python", | ||
| "library_type": "INTEGRATION", | ||
| "repo": "googleapis/google-cloud-python", | ||
| "distribution_name": "pandas-gbq", | ||
| "api_id": "bigquery.googleapis.com", | ||
| "default_version": "", | ||
| "codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team" | ||
| } | ||
| "name": "pandas-gbq", | ||
| "name_pretty": "Google BigQuery connector for pandas", | ||
| "product_documentation": "https://cloud.google.com/bigquery", | ||
| "release_level": "preview", | ||
| "repo": "googleapis/google-cloud-python" | ||
| } No newline at end of file |
There was a problem hiding this comment.
The codeowner_team field was removed during the alphabetical reordering of keys. This field is essential for identifying the owners of the package for automated PR assignments and issue routing. Please restore it.
| { | |
| "name": "pandas-gbq", | |
| "name_pretty": "Google BigQuery connector for pandas", | |
| "product_documentation": "https://cloud.google.com/bigquery", | |
| "api_id": "bigquery.googleapis.com", | |
| "client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/", | |
| "distribution_name": "pandas-gbq", | |
| "issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues", | |
| "release_level": "preview", | |
| "language": "python", | |
| "library_type": "INTEGRATION", | |
| "repo": "googleapis/google-cloud-python", | |
| "distribution_name": "pandas-gbq", | |
| "api_id": "bigquery.googleapis.com", | |
| "default_version": "", | |
| "codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team" | |
| } | |
| "name": "pandas-gbq", | |
| "name_pretty": "Google BigQuery connector for pandas", | |
| "product_documentation": "https://cloud.google.com/bigquery", | |
| "release_level": "preview", | |
| "repo": "googleapis/google-cloud-python" | |
| } | |
| { | |
| "api_id": "bigquery.googleapis.com", | |
| "client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/", | |
| "codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team", | |
| "distribution_name": "pandas-gbq", | |
| "issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues", | |
| "language": "python", | |
| "library_type": "INTEGRATION", | |
| "name": "pandas-gbq", | |
| "name_pretty": "Google BigQuery connector for pandas", | |
| "product_documentation": "https://cloud.google.com/bigquery", | |
| "release_level": "preview", | |
| "repo": "googleapis/google-cloud-python" | |
| } | |
There was a problem hiding this comment.
I have seen this comment about removal of codeowner_team from the .repo-metadate.json file as being problematic on more than one occasion.
For the record, in the google-cloud-python repo, we have moved away from using that field in this file to using a dedicated .github/CODEOWNERS file.
Please avoid this comment going forth for packages in the google-cloud-python repository.
There was a problem hiding this comment.
Thank you for the clarification, @chalmerlowe. I have noted that the codeowner_team field is no longer required for packages within the google-cloud-python repository, as ownership is now managed via the .github/CODEOWNERS file. I will adjust my review process accordingly for this repository.
There was a problem hiding this comment.
LGTM, with the exception of the pandas-gbq prererelease nox session.
This has been an ongoing problem for a number of PRs.
pandas-gbq has been stalling in all the PRs I have worked related to pandas-gbq.
When it stalls, the logs just end without a clue to indicate why the pandas-gbq prerelease session has stalled, so troubleshooting is incredibly problematic.
|
presubmits fixed in #16746. |
3 participants
complete migration of pandas-gbq