Skip to content

chore: specify relative path for packages in pandas-gbq noxfile.py#16746

Merged
chalmerlowe merged 1 commit intomainfrom
fix-for-pandas-gbq
Apr 21, 2026
Merged

chore: specify relative path for packages in pandas-gbq noxfile.py#16746
chalmerlowe merged 1 commit intomainfrom
fix-for-pandas-gbq

Conversation

@ohmayr
Copy link
Copy Markdown
Contributor

@ohmayr ohmayr commented Apr 21, 2026

Use relative paths instead of cloning the entire repo from github and stepping into the sub directory which takes a lot of memory and time and results in the presubmit(s) to timeout.

@ohmayr ohmayr requested review from a team as code owners April 21, 2026 10:36
@ohmayr ohmayr requested review from GarrettWu and removed request for a team April 21, 2026 10:36
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the noxfile.py to install google-cloud-bigquery and google-cloud-bigquery-storage from local relative paths instead of remote git repositories during prerelease dependency installation. I have no feedback to provide.

@ohmayr ohmayr added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2026
@ohmayr ohmayr changed the title chore: fix subpackages path in pandas-gbq noxfile chore: specify relative path for packages in pandas-gbq noxfile.py Apr 21, 2026
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit f1683b0 into main Apr 21, 2026
30 checks passed
@chalmerlowe chalmerlowe deleted the fix-for-pandas-gbq branch April 21, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants