Skip to content

chore: remove references to Python 3.8 and 3.9 #16940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 4 commits into from
May 5, 2026
Merged

chore: remove references to Python 3.8 and 3.9 #16940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2153b1c
feat(pandas-gbq): Update Nox sessions to remove old versions and dead…
chalmerlowe May 5, 2026
0943147
docs(pandas-gbq): Update Python versions in CONTRIBUTING.rst
chalmerlowe May 5, 2026
b41ba48
feat(pandas-gbq): Update runtime version check to Python 3.10
chalmerlowe May 5, 2026
920a4fb
refactor(pandas-gbq): Standardize version check and remove helper
chalmerlowe May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/pandas-gbq/CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ In order to add a feature:
documentation.

- The feature must work fully on the following CPython versions:
3.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.
3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.

- The feature must not add unnecessary dependencies (where
"unnecessary" is of course subjective, but new dependencies should
Expand Down Expand Up @@ -195,11 +195,11 @@ configure them just like the System Tests.

# Run all tests in a folder
$ cd samples/snippets
$ nox -s py-3.8
$ nox -s py-3.10

# Run a single sample test
$ cd samples/snippets
$ nox -s py-3.8 -- -k <name of test>
$ nox -s py-3.10 -- -k <name of test>

********************************************
Note About ``README`` as it pertains to PyPI
Expand All @@ -221,14 +221,12 @@ Supported Python Versions

We support:

- `Python 3.9`_
- `Python 3.10`_
- `Python 3.11`_
- `Python 3.12`_
- `Python 3.13`_
- `Python 3.14`_

.. _Python 3.9: https://docs.python.org/3.9/
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
Comment on lines 230 to 232
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The links for Python 3.13 and 3.14 are missing from the bottom of the file. Since these versions are listed as supported in the list above, their corresponding link targets should be added to avoid broken references in the documentation.

Suggested change
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
.. _Python 3.13: https://docs.python.org/3.13/
.. _Python 3.14: https://docs.python.org/3.14/

Copy link
Copy Markdown
Contributor Author

@chalmerlowe chalmerlowe May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist:
Thanks for doing these checks!

In this case, please note: these links are not missing. They might be outside the diff's context window for the change OR something. But if you check, the lines you ask for are already there.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion. You are correct; upon re-examining the file content, the link definitions for Python 3.13 and 3.14 are indeed present in the file. My previous comment was based on an incomplete view of the file context. Thank you for clarifying.

Expand All @@ -241,7 +239,7 @@ Supported versions can be found in our ``noxfile.py`` `config`_.
.. _config: https://github.com/googleapis/google-cloud-python/blob/main/packages/pandas-gbq/noxfile.py


We also explicitly decided to support Python 3 beginning with version 3.9.
We also explicitly decided to support Python 3 beginning with version 3.10.
Reasons for this include:

- Encouraging use of newest versions of Python 3
Expand Down
6 changes: 0 additions & 6 deletions packages/pandas-gbq/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
"3.12",
"3.13",
"3.14",
# Not supported, but included so that we can explicitly skip the session
# from here. Keep unsupported versions last so that they don't conflict with
# the prerelease_deps session.
"3.9",
]

UNIT_TEST_STANDARD_DEPENDENCIES = [
Expand Down Expand Up @@ -235,8 +231,6 @@ def default(session):
@_calculate_duration
def unit(session):
"""Run the unit test suite."""
if session.python == "3.9":
session.skip("Python 3.9 is not supported.")
default(session)


Expand Down
12 changes: 5 additions & 7 deletions packages/pandas-gbq/pandas_gbq/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,20 @@
# license that can be found in the LICENSE file.

import logging
import sys
import warnings

from pandas_gbq import version as pandas_gbq_version
from pandas_gbq.contexts import Context, context
from pandas_gbq.core.sample import sample

from . import _versions_helpers
from .gbq import read_gbq, to_gbq # noqa

sys_major, sys_minor, sys_micro = _versions_helpers.extract_runtime_version()
if sys_major == 3 and sys_minor < 9:
if sys.version_info < (3, 10):
warnings.warn(
"pandas-gbq no longer supports Python versions older than 3.9. "
"Your Python version is "
f"{sys_major}.{sys_minor}.{sys_micro}. Please update "
"to Python 3.9 or newer to ensure ongoing support. For more details, "
"pandas-gbq no longer supports Python versions older than 3.10. "
f"Your Python version is {sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}. "
"Please update to Python 3.10 or newer to ensure ongoing support. For more details, "
"see: https://cloud.google.com/python/docs/supported-python-versions",
FutureWarning,
)
Expand Down
32 changes: 0 additions & 32 deletions packages/pandas-gbq/pandas_gbq/_versions_helpers.py
View file
Open in desktop

This file was deleted.

Loading