Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/sqlalchemy-bigquery/CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ In order to add a feature:
documentation.

- The feature must work fully on the following CPython versions:
3.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.
3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.

- The feature must not add unnecessary dependencies (where
"unnecessary" is of course subjective, but new dependencies should
Expand Down Expand Up @@ -148,7 +148,7 @@ Running System Tests

.. note::

System tests are only configured to run under Python 3.9, 3.12, and 3.14.
System tests are only configured to run under Python 3.12 and 3.14.
For expediency, we do not run them in older versions of Python 3.

This alone will not run the tests. You'll need to change some local
Expand Down Expand Up @@ -195,11 +195,11 @@ configure them just like the System Tests.

# Run all tests in a folder
$ cd samples/snippets
$ nox -s py-3.9
$ nox -s py-3.10

# Run a single sample test
$ cd samples/snippets
$ nox -s py-3.9 -- -k <name of test>
$ nox -s py-3.10 -- -k <name of test>

********************************************
Note About ``README`` as it pertains to PyPI
Expand All @@ -221,14 +221,12 @@ Supported Python Versions

We support:

- `Python 3.9`_
- `Python 3.10`_
- `Python 3.11`_
- `Python 3.12`_
- `Python 3.13`_
- `Python 3.14`_

.. _Python 3.9: https://docs.python.org/3.9/
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
Expand Down
4 changes: 2 additions & 2 deletions packages/sqlalchemy-bigquery/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ dependencies.

Supported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^
Python >= 3.9, <3.14
Python >= 3.10, <= 3.14

Unsupported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Python <= 3.7.
Python <= 3.9


Mac/Linux
Expand Down
5 changes: 0 additions & 5 deletions packages/sqlalchemy-bigquery/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,13 @@
DEFAULT_PYTHON_VERSION = "3.14"

UNIT_TEST_PYTHON_VERSIONS: List[str] = [
"3.8",
"3.9",
"3.10",
"3.11",
"3.12",
"3.13",
"3.14",
]
ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS)
ALL_PYTHON.extend(["3.7"])
UNIT_TEST_STANDARD_DEPENDENCIES = [
"mock",
"asyncmock",
Expand Down Expand Up @@ -268,8 +265,6 @@ def install_unittest_dependencies(session, *constraints):
def unit(session, protobuf_implementation, install_extras=True):
# Install all test dependencies, then install this package in-place.

if session.python in ("3.7",):
session.skip("Python 3.7 is no longer supported")
if protobuf_implementation == "cpp" and session.python in (
"3.11",
"3.12",
Expand Down
6 changes: 2 additions & 4 deletions packages/sqlalchemy-bigquery/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def readme():
"grpcio >= 1.47.0, < 2.0.0",
"grpcio >= 1.49.1, < 2.0.0; python_version =='3.11'",
"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
"pyarrow >= 5.0.0",
"pyarrow >= 6.0.0",
],
}

Expand Down Expand Up @@ -101,8 +101,6 @@ def readme():
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Comment on lines 104 to 106
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Trove classifiers are missing entries for Python 3.13 and 3.14, which are stated as supported in the documentation and noxfile.py. According to the general rules, project metadata should be updated to reflect the supported versions when updating the minimum Python version.

Suggested change
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
References
  1. When updating the minimum supported Python version in runtime checks, ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.

Expand All @@ -123,7 +121,7 @@ def readme():
"sqlalchemy>=1.4.16,<3.0.0",
],
extras_require=extras,
python_requires=">=3.8, <3.15",
python_requires=">=3.10, <3.15",
tests_require=["packaging", "pytz"],
entry_points={
"sqlalchemy.dialects": ["bigquery = sqlalchemy_bigquery:BigQueryDialect"]
Expand Down
15 changes: 15 additions & 0 deletions packages/sqlalchemy-bigquery/testing/constraints-3.10.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# This constraints file is used to check that lower bounds
# are correct in setup.py
# List *all* library dependencies and extras in this file.
# Pin the version to the lower bound.
#
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
sqlalchemy==1.4.16
google-auth==2.14.1
google-cloud-bigquery==3.20.0
google-cloud-bigquery-storage==2.18.0
google-api-core==2.11.1
grpcio==1.47.0
numpy==1.26.4
alembic==1.7.7
Comment thread
chalmerlowe marked this conversation as resolved.
pyarrow==6.0.0
13 changes: 0 additions & 13 deletions packages/sqlalchemy-bigquery/testing/constraints-3.8.txt

This file was deleted.

13 changes: 0 additions & 13 deletions packages/sqlalchemy-bigquery/testing/constraints-3.9.txt

This file was deleted.

Loading