Skip to content

Feat/drop python 3.7 3.9 google auth httplib2#16979

Closed
chalmerlowe wants to merge 5 commits into
mainfrom
feat/drop-python-3.7-3.9-google-auth-httplib2
Closed

Feat/drop python 3.7 3.9 google auth httplib2#16979
chalmerlowe wants to merge 5 commits into
mainfrom
feat/drop-python-3.7-3.9-google-auth-httplib2

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@chalmerlowe chalmerlowe closed this May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.9, updating configuration in noxfile.py, setup.py, and pytest.ini, and adding a Python 3.10 constraints file. Feedback suggests including Python 3.13 and 3.14 in the test matrix and Trove classifiers to align with the project's default version, and recommends a minor version bump for this breaking change.

Comment on lines 45 to 47
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When dropping support for Python 3.9, ensure that the project's metadata in 'setup.py' is updated to reflect the new minimum version in 'python_requires' and Trove classifiers. Additionally, since dropping a Python version is a breaking change, prefer a minor version bump over a patch version bump to maintain the ability to provide patches for the previous version. Consider also adding Trove classifiers for Python 3.13 and 3.14 to align with the 'DEFAULT_PYTHON_VERSION' specified in 'noxfile.py'.

References
  1. When updating the minimum supported Python version, ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.
  2. When a release introduces breaking changes such as dropping support for specific Python versions, prefer a minor version bump over a patch version bump.

Comment on lines 37 to 39
"3.10",
"3.11",
"3.12",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The unit test matrix appears to be missing Python 3.13 and 3.14. Since 'DEFAULT_PYTHON_VERSION' is set to '3.14', please verify that these versions are not already present in 'UNIT_TEST_PYTHON_VERSIONS' elsewhere in the file before adding them. If they are indeed missing, they should be included to ensure compatibility and test coverage for the latest stable and upcoming Python releases.

References
  1. Verify that suggested additions to a configuration list (such as Python versions in a test matrix) are not already present in the file before recommending their inclusion to avoid false positive suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant