chore: refactor tests related to AIP 4235#17027
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies test templates and golden files by replacing None assignments with empty strings to clear auto-populated fields in request objects. The reviewer suggests that using del is more appropriate than assigning an empty string, as the latter explicitly sets a value rather than unsetting the field. This distinction is important for backends that no longer treat empty strings as 'no-op' signals, especially when dealing with proto3 optional fields.
parthea
force-pushed
the
use-empty-string-instead-of-none
branch
from
55fb3e2 to
ef0883c
Compare
parthea
changed the title
parthea
force-pushed
the
use-empty-string-instead-of-none
branch
from
ef0883c to
a527b09
Compare
parthea
changed the title
parthea
force-pushed
the
use-empty-string-instead-of-none
branch
from
a527b09 to
68a6358
Compare
parthea
force-pushed
the
use-empty-string-instead-of-none
branch
from
68a6358 to
e07298e
Compare
parthea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #16944. Please review #16944 first.
The PR addresses the feedback in #16944 (comment) , specifically 2.