Skip to content

fix(firestore): BulkWriter pop from an empty deque #17490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 3 commits into from
Jul 27, 2026
+42 −0
Merged

fix(firestore): BulkWriter pop from an empty deque #17490

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6023562
fix(firestore): BulkWriter pop from an empty deque
daniel-sanche Jun 16, 2026
0770b5d
Update packages/google-cloud-firestore/google/cloud/firestore_v1/bulk…
daniel-sanche Jun 17, 2026
810d0f8
added test
daniel-sanche Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/google-cloud-firestore/google/cloud/firestore_v1/bulk_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,8 @@ def _schedule_ready_retries(self) -> None:
)

for _ in range(take_until_index):
if not self._retries:

@chalmerlowe chalmerlowe Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that cover still passes.

#QUESTION
#NIT
Is this conditional something that should be tested to ensure we don't have regression if this code ever changes?

I will approve and defer to you in determining whether adding at test is necessary.

break
retry: OperationRetry = self._retries.popleft()
retry.retry(self)
return None
Expand Down
Loading